We switched libossaudio to sndio, but programs keep opening /dev/mixer
but don't use it; so it could be replaced by /dev/null. It would be
even better, to not use descriptors at all, but that's more difficult
for gstreamer.

This change is important because /dev/mixer access will be disallowed
to regular users for security reasons (do you want random big programs
to be able to run random ioctls on /dev/mixer?)

OK?

BTW, any help to update other ports is welcome, this is my list of
programs that require access to /dev/mixer but don't use it:
  - emulators/gambatte
  - sysutils/conky
  - sysutils/gkrellm/plugins/volume
  - sysutils/tpb
  - telephony/iaxclient

Index: Makefile
===================================================================
RCS file: /cvs/ports/multimedia/gstreamer-0.10/plugins-good/Makefile,v
retrieving revision 1.113
diff -u -p -u -p -r1.113 Makefile
--- Makefile    1 Feb 2020 15:04:26 -0000       1.113
+++ Makefile    11 Apr 2020 16:54:59 -0000
@@ -18,7 +18,7 @@ PKGNAME-dv=           gstreamer-dv-${V}
 PKGNAME-caca=          gstreamer-libcaca-${V}
 EPOCH-main=            0
 
-REVISION-main=         25
+REVISION-main=         26
 REVISION-aalib=                13
 REVISION-caca=         13
 REVISION-dv=           12
Index: patches/patch-sys_oss_gstossmixerelement_c
===================================================================
RCS file: patches/patch-sys_oss_gstossmixerelement_c
diff -N patches/patch-sys_oss_gstossmixerelement_c
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-sys_oss_gstossmixerelement_c  11 Apr 2020 16:54:59 -0000
@@ -0,0 +1,14 @@
+$OpenBSD$
+
+Index: sys/oss/gstossmixerelement.c
+--- sys/oss/gstossmixerelement.c.orig
++++ sys/oss/gstossmixerelement.c
+@@ -42,7 +42,7 @@
+ GST_DEBUG_CATEGORY_EXTERN (oss_debug);
+ #define GST_CAT_DEFAULT oss_debug
+ 
+-#define DEFAULT_DEVICE       "/dev/mixer"
++#define DEFAULT_DEVICE       "/dev/null"
+ #define DEFAULT_DEVICE_NAME  NULL
+ 
+ enum

Reply via email to