I know i am a bit late to the party but here are my 2 cents:

1. without overriding FZF_DEFAULT_COMMAND, this port does not work from a
   shell that has no `set -o pipefail`:

$ fzf

  [Command failed: set -o pipefail; command find -L . -mindepth 1 \( -path ..
>

i think that this is a bug and opened an issue:
https://github.com/junegunn/fzf/issues/1993

While trivial, it's annoying, and of course it might not make it into
upstream for whatever reason.  For the time being I am proposing the
following local patch for constants.go:

--- constants.go.orig   Sun Apr 19 20:40:59 2020
+++ constants.go        Sun Apr 19 20:41:36 2020
@@ -59,7 +59,7 @@

 func init() {
        if !util.IsWindows() {
-               defaultCommand = `set -o pipefail; command find -L . -mindepth 
1 \( -path '*/\.*' -o -fstype 'sysfs' -o -fstype 'devfs' -o -fstype 'devtmpfs' 
-o -fstype'proc' \) -prune -o -type f -print -o -type l -print 2> /dev/null | 
cut -b3-`
+               defaultCommand = `sh -c "command find -L . -mindepth 1 -path 
'*/\.*' -prune -o -type f -print -o -type l -print 2> /dev/null | cut -b3-"`
        } else if os.Getenv("TERM") == "cygwin" {
                defaultCommand = `sh -c "command find -L . -mindepth 1 -path 
'*/\.*' -prune -o -type f -print -o -type l -print 2> /dev/null | cut -b3-"`
        }


2. i am a daily user of fzf, also from vim and nvim, integrated with
numerous plugins, but i dont appreciate the package (any package)
installing plugins into my vim runpath whether i asked for it or not.
(also it does not work by default with nvim).  The documented and
recommended approach is to add the folder holding the `.vim` file as
another plugin (if used with `vim-plug` from the same author as fzf):

" e.g. on macOS:
Plug '/usr/local/opt/fzf'   " <- `fzf.vim` from `brew install fzf`
Plug 'junegunn/fzf.vim'     " <- the vim fzf plugin itself

So I think the more generic approach would be to install the `.vim`
file under `/usr/local/share/fzf/...` and use the vim/nvim settings to
discover and load it:

" openbsd:
Plug '/usr/local/share/fzf' " <- where the package should install
Plug 'junegunn/fzf.vim'


diff --git a/sysutils/fzf/Makefile b/sysutils/fzf/Makefile
index 1a807ae1c..94a704a1e 100644
--- a/sysutils/fzf/Makefile
+++ b/sysutils/fzf/Makefile
@@ -4,6 +4,8 @@ COMMENT =       command-line fuzzy finder

 DISTNAME =     fzf-0.21.1

+REVISION =     0
+
 CATEGORIES =   sysutils

 HOMEPAGE =     https://github.com/junegunn/fzf
@@ -33,7 +35,7 @@ ALL_TARGET =  github.com/junegunn/fzf
 ZSH_SITE =     ${PREFIX}/share/zsh/site-functions
 FISH_SITE =    ${PREFIX}/share/fish/functions
 BASH_SITE =    ${PREFIX}/share/fzf/bash
-VIMFILES =     ${PREFIX}/share/vim/vimfiles
+VIMFILES =     ${PREFIX}/share/fzf
 VIM_PLUGIN =   ${VIMFILES}/plugin
 VIM_DOC =      ${VIMFILES}/doc
 SUBST_VARS +=  BASH_SITE FISH_SITE VIMFILES<Paste>


--- PLIST.orig  Sun Apr 19 18:16:45 2020
+++ PLIST       Sun Apr 19 21:00:23 2020
@@ -11,12 +11,10 @@
 share/fzf/bash/
 share/fzf/bash/completion.bash
 share/fzf/bash/key-bindings.bash
-share/vim/
-share/vim/vimfiles/
-share/vim/vimfiles/doc/
-share/vim/vimfiles/doc/fzf.txt
-share/vim/vimfiles/plugin/
-share/vim/vimfiles/plugin/fzf.vim
+share/fzf/doc/
+share/fzf/doc/fzf.txt
+share/fzf/plugin/
+share/fzf/plugin/fzf.vim
 share/zsh/
 share/zsh/site-functions/
 share/zsh/site-functions/_fzf_completion


-f
-- 
a man serves best, when he serves himself.

Reply via email to