On 2020/04/23 13:37, Ian Darwin wrote:
> The guys who make many of the New York Times crosswords use
> and recommend this crossword-maker.
>
> Since there is an unrelated crossfire-client in games/,
> would it be better to keep the camelcased name CrossFire
> (at least for the package and directory names, not the startup script)
> instead of lowercasing these?
I don't see anything granting us distribution rights ("About CrossFire"
in the application says "All rights reserved") so I think PERMIT_PACKAGE
and PERMIT_DISTFILES need to be set to disable distribution.
As-is the script doesn't work, either it needs a lowercase PKGNAME or
files/crossfire.sh needs adjusting to use the camelcase one. I'd prefer
a lowercase PKGNAME.
DISTNAME can be set based on V:
CrossFire-${V:S/./_/g}-linux
Nitpicking, the tabs in Makefile are a bit awkward with ports-standard
8 columns.
> It works fine on jdk-11, should we make that the dep to encourage
> ppl to move along?
I'd go with keeping it set to what's actually correct i.e. 1.8+.
I'd be quite happy if javaPathHelper picked up jdk 11 at runtime more
often (currently it looks at +REQUIRING to determine which version to
use, it could look at +CONTENTS instead to prefer 11 where possible).
so that where a port supports jdk 11 it always uses that if installed.
That would definitely be a post-release change though.
