After unlock will be a good time to get this in. I don't expect build time problems but there's a chance that some software might possibly run into runtime problems (one thing changed was enabling cert verification by default, which is a good thing but might impact some broken setups :)
Update is OK with me. This is an important port in the ecosystem and really wants to be actively maintained. On 2020/05/12 09:27, Paco Esteban wrote: > Hi ports@, > > (this is for after unlock, of course) > > Here's an update for www/py-urllib3. This is needed for tests to pass > on www/py-httpie which I've sent on another email. > > There are lots of changes since we pass from 1.24.3 to 1.25.9. You can > see them here: > > https://github.com/urllib3/urllib3/blob/master/CHANGES.rst > > I've been using it for some weeks now without any issue. About its > regression tests, before the update they were crashing for me. After > the update 22 tests fail. All of them related to network access (it > tries to access 10.255.255.1 and localhost it fails). I guess this is > a combination of non-existing addresses + PRIVSEP setup kicking in. > > For its consumers all behave the same tests wise before and after the > update as far as I can see (that's for the ones that have tests). > > As this is a port that touches a pretty big tree of ports (specially > through www/py-requests) more eyes on this diff are very welcome. > > Comments ? ok ? > > Index: Makefile > =================================================================== > RCS file: /home/cvs/ports/www/py-urllib3/Makefile,v > retrieving revision 1.16 > diff -u -p -r1.16 Makefile > --- Makefile 7 Nov 2019 15:05:14 -0000 1.16 > +++ Makefile 18 Apr 2020 20:13:36 -0000 > @@ -2,7 +2,7 @@ > > COMMENT= HTTP library for Python > > -MODPY_EGG_VERSION=1.24.3 > +MODPY_EGG_VERSION=1.25.9 > DISTNAME= urllib3-${MODPY_EGG_VERSION} > PKGNAME= py-urllib3-${MODPY_EGG_VERSION} > > @@ -22,8 +22,12 @@ MODPY_SETUPTOOLS= Yes > MODPY_PYTEST= Yes > > TEST_DEPENDS = devel/py-mock${MODPY_FLAVOR} \ > + net/py-socks${MODPY_FLAVOR} \ > sysutils/py-psutil${MODPY_FLAVOR} \ > + security/py-trustme${MODPY_FLAVOR} \ > www/py-tornado${MODPY_FLAVOR} > + > +TEST_ENV += PYTHONPATH=${WRKSRC}/src > > FLAVORS = python3 > FLAVOR ?= > Index: distinfo > =================================================================== > RCS file: /home/cvs/ports/www/py-urllib3/distinfo,v > retrieving revision 1.12 > diff -u -p -r1.12 distinfo > --- distinfo 21 Jun 2019 06:24:44 -0000 1.12 > +++ distinfo 18 Apr 2020 20:10:40 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (urllib3-1.24.3.tar.gz) = I5Omlc0Sr+3Q3LJv5dUNDPJI5aZvddvYmj1OszOmGvQ= > -SIZE (urllib3-1.24.3.tar.gz) = 232237 > +SHA256 (urllib3-1.25.9.tar.gz) = MBgpTr785lcqR08GBMICHjOz/YAG7NEdYhB6XSqWNSc= > +SIZE (urllib3-1.25.9.tar.gz) = 254921 > Index: patches/patch-setup_cfg > =================================================================== > RCS file: patches/patch-setup_cfg > diff -N patches/patch-setup_cfg > --- patches/patch-setup_cfg 7 Nov 2019 15:05:14 -0000 1.1 > +++ /dev/null 1 Jan 1970 00:00:00 -0000 > @@ -1,16 +0,0 @@ > -$OpenBSD: patch-setup_cfg,v 1.1 2019/11/07 15:05:14 kmos Exp $ > - > -Fix format to work with modern pytest > - > -Index: setup.cfg > ---- setup.cfg.orig > -+++ setup.cfg > -@@ -18,7 +18,7 @@ requires-dist = > - ipaddress; python_version=="2.7" and extra == 'secure' > - PySocks>=1.5.6,<2.0,!=1.5.7; extra == 'socks' > - > --[pytest] > -+[tool:pytest] > - xfail_strict = true > - > - [egg_info] > > -- > Paco Esteban. > 0x5818130B8A6DBC03 >
