On Sun, May 17, 2020 at 02:08:18PM -0700, Andrew Hewus Fresh wrote:
> On Sun, May 17, 2020 at 10:46:42PM +0200, Charlene Wendling wrote:
> > Hi,
> > 
> > While testing the p5-Email-Filter-Rules submission from Andrew, i'm
> > greeted with:
> 
> Oh right, I guess I last tested that before Module::Pluggable got
> removed from core.  Sigh.  Not sure it's been in long enough to need a
> REVISION, but either way

Oh, I misread which thing was missing the RUN_DEPENDS.  Sigh.  But, that
looks like the right fix, that I wish had been found post perl 5.30 and
pre OpenBSD 6.7.  Oh well, still (if it builds without the BUILD_DEPENDS)


> OK afresh1@
> 
> > 
> > ===>  Regression tests for p5-Email-Filter-Rules-1.2                        
> >                                                                             
> >                                        
> > PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" 
> > "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 
> > 'blib/lib', 'blib/arch')" t/*.t                            
> >                                                                             
> >                                                                             
> >                                        
> > #   Failed test 'use Email::Filter;'                                        
> >                                                                             
> >                                        
> > #   at t/001_load.t line 6.                                                 
> >                                                                             
> >                                        
> > #     Tried to use 'Email::Filter'.                                         
> >                                                                             
> >                                        
> > #     Error:  Can't locate Module/Pluggable.pm in @INC (you may need to 
> > install the Module::Pluggable module) (@INC contains: 
> > /usr/ports/pobj/p5-Email-Filter-Rules-1.2/Email-Filter-Rules-1.2/
> > blib/lib 
> > /usr/ports/pobj/p5-Email-Filter-Rules-1.2/Email-Filter-Rules-1.2/blib/arch 
> > /usr/local/libdata/perl5/site_perl/amd64-openbsd 
> > /usr/local/libdata/perl5/site_perl /usr/libdata/perl5/amd6
> > 4-openbsd /usr/libdata/perl5 .) at 
> > /usr/local/libdata/perl5/site_perl/Email/FolderType.pm line 8.   
> > 
> > The below diff fixes that, and while here i've removed the useless
> > BUILD_DEPENDS=RUN_DEPENDS.
> > 
> > OK?
> > 
> > Charlène.
> > 
> > 
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/mail/p5-Email-Filter/Makefile,v
> > retrieving revision 1.8
> > diff -u -p -u -p -r1.8 Makefile
> > --- Makefile        12 Jul 2019 20:47:31 -0000      1.8
> > +++ Makefile        17 May 2020 20:42:09 -0000
> > @@ -3,6 +3,7 @@
> >  COMMENT =  library for creating easy email filters
> >  
> >  DISTNAME = Email-Filter-1.034
> > +REVISION = 0
> >  CATEGORIES =       mail
> >  
> >  HOMEPAGE = http://emailproject.perl.org/
> > @@ -17,11 +18,10 @@ PKG_ARCH =      *
> >  CPAN_AUTHOR =      RJBS
> >  
> >  RUN_DEPENDS =      devel/p5-Class-Trigger>=0.08 \
> > +           devel/p5-Module-Pluggable \
> >             mail/p5-Email-LocalDelivery>=0.07 \
> >             mail/p5-Email-Simple>=1.91 \
> >             devel/p5-IPC-Run>=0.77
> > -
> > -BUILD_DEPENDS =    ${RUN_DEPENDS}
> >  
> >  MAKE_ENV = TEST_POD=Yes
> >  
> 
> -- 
> andrew - http://afresh1.com
> 
> Speed matters.  
> Almost as much as some things, and nowhere near as much as others.
>                       -- Nick Holland
> 

-- 
andrew - http://afresh1.com

Adding manpower to a late software project makes it later.

Reply via email to