On 2020/05/22 12:10, Antoine Jacoutot wrote: > On Fri, May 22, 2020 at 08:57:21AM +0100, Stuart Henderson wrote: > > IIRC it's installed there on purpose, exactly so that it is not > > automatically picked up. > > Indeed. > But should we change the rule now and install it under the default path?
I don't think this is something to be taken likely. As you know, libinotify has different behaviour than linux inotify. It feels like the problem with high FD use is manageable while it's opt-in and only a few ports are involved, but if this is turned on for all ports that want it we'll at least need to look closer into how they all behave. Also we don't know how some programs will cope with the various inotify events that aren't supported by libinotify. I've made a list of ports with "inotify" in build log and not in the port directory, it's not totally accurate but gives a reasonable picture - obviously this doesn't mean that all of these ports will start using it but it's a starting point of places where we'd need to look if we do decide this is useful. Compared to the work involved in looking at all of these (and future ports), and possibly having to patch to disable libinotify in some cases (which is often harder than patching a port to allow it to find files in an unusual location), it feels like patching the few ports that do really need libinotify is less work and easier work. comms/smstools databases/tdb devel/clang-tools-extra devel/glib2 devel/kf5/extra-cmake-modules devel/kf5/kcoreaddons devel/libev devel/libivykis devel/libtalloc devel/p5-EV devel/p5-File-ChangeNotify devel/py-gevent devel/spidermonkey60 devel/spidermonkey68 editors/emacs games/mirrormagic games/openclonk graphics/feh lang/mono mail/dovecot mail/extsmail mail/mozilla-thunderbird mail/mutt mail/neomutt mail/rspamd math/graphviz net/avahi net/coredns net/dnsmasq net/gdnsd net/ruby-eventmachine net/samba net/transmission sysutils/conky sysutils/consolekit sysutils/coreutils sysutils/direvent sysutils/logfmon sysutils/rsyslog sysutils/ruby-libvirt sysutils/syslog-ng telephony/asterisk textproc/calibre textproc/wkhtmltopdf www/firefox-esr www/mozilla-firefox www/tor-browser/browser x11/dbus x11/e17/ecore x11/e17/eio x11/e17/evas x11/ede/lib x11/emelfm2 x11/gnome/vfs2 x11/kde/libs3 x11/kde4/baloo x11/kde4/pim x11/kde4/workspace x11/qt4 x11/rox-filer x11/rxvt-unicode
