On Sat 06/06/2020 10:04, Thomas Frohwein wrote: > On Sat, Jun 06, 2020 at 09:25:42AM +0200, Rafael Sadowski wrote: > > On Sat Jun 06, 2020 at 08:10:37AM +0200, Bjorn Ketelaars wrote: > [...] > > > I think it is nice to have this tool in ports. Two comments/questions: > > > - I'm not sure that www is the right category, is devel not more > > > appropriate? > > > > IMHO devel is already too full. > > I chose www because that's where jupyter-notebook lives. The line in > www/jupyter-notebook is actually CATEGORIES=www devel. > Since this port is so closely tied to jupyter-notebook, I suggest using > the same line, that is both www and devel. > > > > - Maybe add HOMEPAGE=https://github.com/kiwi0fruit/ipynb-py-convert to > > > Makefile? > > You caught me there, thanks. Same for NO_TEST=Yes. > > I added these 3 changes to a fresh tarball which is attached. > > ok?
OK bket@
