On Sun, Jun 07, 2020 at 06:10:13AM +0000, niamkik wrote:
> Hi James,
> 
> > A couple issues right off the bat. You don't need a REVISION marker
> > since this would be the initial import. It also looks like 20.01.2 was
> > release on May 3rd.
> 
> Yes, I was working on this port in February/March, so, I forgot to check if a 
> new version was available. I corrected it.
> 
> > pkg/PLIST seems to be empty, so not sure how this port/pkg would even
> > install anything. You also have CONFIGURE_ENV set CC=egcc but don't
> > depend on ports gcc anywhere. You might want to look into the COMPILER
> > option if you really need to depend on ports gcc.
> 
> It seems I send this port in hurry without checking everything. My bad. I 
> give you the PLIST file generated for the last release (20.01.2).
> 
> Thanks for the review.
> 

Thanks for fixing up the port. Portwise it looks good to me. I'll give
it a build this evening. I don't have much experience using ports-gcc so
hopefully someone else with who does can chime in.

Reply via email to