On Sat, 27 Jun 2020 00:29:05 +0200
Jeremie Courreges-Anglas <[email protected]> wrote:
> On Fri, Jun 26 2020, YASUOKA Masahiko <[email protected]> wrote:
>> Hi,
>>
>> Currently emacs is using an old way to create a process with a pty.
>> OpenBSD has posix_openpt(3) now, so emacs should use it.
>>
>> I actually hit a problem that Mew could not start gnupg properly.
>
> Makes sense.
>
>> # I sent a bug report to the upstream as well.
>
> I think you reversed configure.ac and configure.ac.orig in the patch in
> your bug report:
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42059
Thanks, it was reversed. I corrected the diff by a reply.
> Regarding the ports tree patch, the order of the operating systems list
> is different from your patch for upstream. I would expect "openbsd" to
> go between "freebsd" and "netbsd", but I can live with that. :)
:)
>> ok?
>
> Works for me, let's see if it introduces any issue. ok jca@
committed. Thanks,
>> Index: Makefile
>> ===================================================================
>> RCS file: /disk/cvs/openbsd/ports/editors/emacs/Makefile,v
>> retrieving revision 1.93
>> diff -u -p -r1.93 Makefile
>> --- Makefile 10 Nov 2019 21:50:23 -0000 1.93
>> +++ Makefile 26 Jun 2020 10:02:29 -0000
>> @@ -3,7 +3,7 @@
>> COMMENT= GNU editor: extensible, customizable, self-documenting
>>
>> VERSION= 26.3
>> -REVISION= 1
>> +REVISION= 2
>> DISTNAME= emacs-${VERSION}
>>
>> CATEGORIES= editors
>> Index: patches/patch-configure
>> ===================================================================
>> RCS file: /disk/cvs/openbsd/ports/editors/emacs/patches/patch-configure,v
>> retrieving revision 1.17
>> diff -u -p -r1.17 patch-configure
>> --- patches/patch-configure 25 Sep 2019 22:10:51 -0000 1.17
>> +++ patches/patch-configure 26 Jun 2020 10:02:29 -0000
>> @@ -13,3 +13,18 @@ Index: configure
>> ;;
>> esac
>>
>> +@@ -18602,12 +18600,12 @@ case $opsys in
>> +
>> + ;;
>> +
>> +- gnu | openbsd | qnxnto )
>> ++ gnu | qnxnto )
>> + $as_echo "#define FIRST_PTY_LETTER 'p'" >>confdefs.h
>> +
>> + ;;
>> +
>> +- gnu-linux | gnu-kfreebsd | dragonfly | freebsd | netbsd | darwin | nacl )
>> ++ openbsd | gnu-linux | gnu-kfreebsd | dragonfly | freebsd | netbsd |
>> darwin | nacl )
>> + if test "x$ac_cv_func_grantpt" = xyes; then
>> +
>> + $as_echo "#define UNIX98_PTYS 1" >>confdefs.h
>>
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
