On Mon, Jul 06, 2020 at 05:31:31PM +0200, 3un0s wrote:

> > - what is the chmod for?

> > - tests seem broken

> > ============================= test session starts
> > ============================== platform openbsd6 -- Python 2.7.18,
> > pytest-4.4.0, py-1.8.0, pluggy-0.11.0 rootdir:
> > /usr/obj/ports/py-css-parser-1.0.4/css-parser-1.0.4

> > ========================= no tests ran in 0.01 seconds
> > ========================= ERROR: file not found: lib/css-parser

> I'll redo the COMMENT/DESCR sections

> There's no need for py2 version so I will change it to py3 only

> chmod isn't needed, I based my work on the textproc/py-cssutils port but
> found out that probably no other package uses it, will delete it

> If there's no tests for release tar.gz should I just put NO_TEST = yes
> in the Makefile?

Yes. Put a comment above NO_TEST explaining that there aren't tests in the
the release tarball. Bonus points for sending a pull request upstream to
include the tests in future release tarballs.

--Kurt

Reply via email to