On Sat, Jul 18, 2020 at 12:29:54PM +0000, Martin wrote: > Abort trap (core dumped) appeared exactly after updating 6.7 to -current with > previously installed aria2 from 6.7 -stable package. > Rebuilding www/aria2 from 6.7 -current port didn't fix Abort trap (core > dumped). > > It seems aria2 port is broken with new SSL/TLS on 6.7 -current.
Since TLS_method() now defaults to TLSv1.3, this port doesn't do the translation from TLSv1.3 to its internal version defines correctly. More precisely, it will retrieve TLS1_3_VERSION from SSL_version(3), but as TLS1_3_VERSION is currently not publicly defined, it will set its internal version to TLS_PROTO_NONE in https://github.com/aria2/aria2/blob/master/src/LibsslTLSSession.cc#L217 then hit this assert(): https://github.com/aria2/aria2/blob/master/src/SocketCore.cc#L987 The easiest fix probably is to define TLS1_3_VERSION to the correct value from the environment. There are two #ifdef TLS1_3_VERSION: https://github.com/aria2/aria2/blob/master/src/LibsslTLSSession.cc#L210-L214 https://github.com/aria2/aria2/blob/master/src/LibsslTLSContext.cc#L116-L120 Index: Makefile =================================================================== RCS file: /var/cvs/ports/www/aria2/Makefile,v retrieving revision 1.59 diff -u -p -r1.59 Makefile --- Makefile 15 Jul 2020 21:13:23 -0000 1.59 +++ Makefile 18 Jul 2020 16:48:19 -0000 @@ -7,6 +7,7 @@ V = 1.35.0 DISTNAME = aria2-${V} CATEGORIES = www HOMEPAGE = https://aria2.github.io/ +REVISION = 0 MAINTAINER = Gonzalo L. R. <[email protected]> @@ -32,7 +33,7 @@ TEST_DEPENDS = ${BUILD_DEPENDS} WANTLIB += c cares crypto expat iconv intl m pthread sqlite3 ssh2 ssl z ${COMPILER_LIBCXX} CONFIGURE_STYLE = gnu -CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include" \ +CONFIGURE_ENV = CPPFLAGS="-DTLS1_3_VERSION=0x0304 -I${LOCALBASE}/include" \ LDFLAGS="-L${LOCALBASE}/lib" CONFIGURE_ARGS += --disable-rpath \
