On Sun, Jul 26, 2020 at 01:28:19PM +0000, wen heping wrote:
> Hi, ports@:
>
> Here is a patch for devel/p5-Moose to update to 2.2013:
> i) It build well and pass all tests on amd64-current system.
> ii) Two new ports should been added : p5-Devel-OverloadInfo and
> p5-Test-CleanNamespaces, which I submitted the patch yesterday.
> iii) Many(76) ports depends on p5-Moose, most of it build well and
> pass all tests.
> iv) Several p5-Catalyst-? ports failed tests, but it was not caused by
> this patch, the Catalyst in our portstree is too old. It would be fixed after
> we update Catalyst.
> v) www/p5-WWW-Tumblr build well but failed tests, do not know why,
> maybe caused by network access.
>
> Cheers !
> wen
>
> Index: devel/p5-MooseX-Clone/Makefile
This I OK'd in the separate email, was there something different in this
version?
> Index: devel/p5-MooseX-Getopt/Makefile
This one I haven't had time to look at yet, but the Moose update doesn't
require it unless it was required to make it work with the new version
of Moose.
The Moose update though had some dependency issues, I didn't look too
hard but instead started with a clean portgen(1) update and then added
the optional TEST_DEPENDS that it wanted until I didn't skip tests that
needed dependencies that were already ported.
A few other super minor cleanups, like updating the DESCR and COMMENT
to what upstream says along with a few comments in the Makefile about
missing dependencies.
I specifically commented out Moose::Conflicts and the moose-outdated
script because it's not particularly useful with ports but only when
using normal CPAN clients and we don't have some of the dependencies it
wants ported over.
Comments? OK?
(It does require some of the new modules that wen heping has already
updated with my suggestions)
Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Moose/Makefile,v
retrieving revision 1.29
diff -u -p -r1.29 Makefile
--- Makefile 3 Jul 2020 21:45:01 -0000 1.29
+++ Makefile 31 Jul 2020 02:55:32 -0000
@@ -1,59 +1,65 @@
# $OpenBSD: Makefile,v 1.29 2020/07/03 21:45:01 sthen Exp $
-COMMENT= complete modern object system for perl 5
+COMMENT= postmodern object system for Perl 5
MODULES= cpan
-DISTNAME= Moose-2.1204
+DISTNAME= Moose-2.2013
+CPAN_AUTHOR= ETHER
CATEGORIES= devel
-REVISION= 2
-
-# perl
-PERMIT_PACKAGE= Yes
-
-FIX_EXTRACT_PERMISSIONS = Yes
-WANTLIB += c perl
+FIX_EXTRACT_PERMISSIONS= Yes
-CPAN_AUTHOR= ETHER
+# Perl
+PERMIT_PACKAGE= Yes
-BUILD_DEPENDS= devel/p5-Task-Weaken
+WANTLIB = c perl
-RUN_DEPENDS= devel/p5-Class-Load-XS \
- devel/p5-Data-OptList \
+# If we wanted moose-outdated we could port
+# p5-Module-Runtime-Conflicts>=0.002
+# and add devel/p5-Dist-CheckConflicts>=0.02
+# but for now it is @comment'ed out
+
+RUN_DEPENDS= devel/p5-Class-Load>=0.09 \
+ devel/p5-Class-Load-XS>=0.01 \
+ devel/p5-Data-OptList>=0.107 \
devel/p5-Devel-GlobalDestruction \
- devel/p5-Devel-StackTrace \
- devel/p5-Dist-CheckConflicts \
- devel/p5-Eval-Closure \
- devel/p5-List-MoreUtils \
- devel/p5-MRO-Compat \
+ devel/p5-Devel-OverloadInfo>=0.005 \
+ devel/p5-Devel-StackTrace>=2.03 \
+ devel/p5-Eval-Closure>=0.04 \
+ devel/p5-MRO-Compat>=0.05 \
devel/p5-Module-Runtime>=0.014 \
- devel/p5-Package-DeprecationManager>=0.13 \
- devel/p5-Package-Stash \
- devel/p5-Package-Stash-XS \
- devel/p5-Params-Util \
- devel/p5-Sub-Exporter \
- devel/p5-Sub-Name \
- devel/p5-Try-Tiny
-
-TEST_DEPENDS=databases/p5-DBM-Deep \
- devel/p5-Class-Load \
- devel/p5-DateTime-Calendar-Mayan \
+ devel/p5-Package-DeprecationManager>=0.11 \
+ devel/p5-Package-Stash>=0.32 \
+ devel/p5-Package-Stash-XS>=0.24 \
+ devel/p5-Params-Util>=1.0 \
+ devel/p5-Sub-Exporter>=0.980 \
+ devel/p5-Sub-Identify \
+ devel/p5-Sub-Name>=0.20 \
+ devel/p5-Try-Tiny>=0.17
+
+TEST_DEPENDS= devel/p5-CPAN-Meta-Check>=0.011 \
+ devel/p5-Test-CleanNamespaces>=0.13 \
+ devel/p5-Test-Fatal>=0.001 \
+ devel/p5-Test-Requires>=0.05
+
+# Optional depends to avoid skiping tests
+# Some tests would also like p5-Types-Standard
+TEST_DEPENDS+= databases/p5-DBM-Deep \
+ devel/p5-Algorithm-C3 \
+ devel/p5-Data-Visitor \
devel/p5-DateTime-Format-MySQL \
devel/p5-Declare-Constraints-Simple \
- devel/p5-Devel-GlobalDestruction \
devel/p5-IO-String \
- devel/p5-Locale-US \
devel/p5-Module-Refresh \
- devel/p5-Module-Runtime \
- devel/p5-MRO-Compat \
- devel/p5-Params-Coerce \
- devel/p5-Sub-Name \
+ devel/p5-Moo \
+ devel/p5-MooseX-MarkAsMethods \
+ devel/p5-PadWalker \
+ devel/p5-SUPER \
devel/p5-Test-Deep \
- devel/p5-Test-Fatal \
+ devel/p5-Test-LeakTrace \
+ devel/p5-Test-Memory-Cycle \
devel/p5-Test-Output \
- devel/p5-Test-Requires \
- textproc/p5-Regexp-Common \
- www/p5-libwww \
- www/p5-URI
+ devel/p5-Test-Warnings \
+ textproc/p5-List-SomeUtils
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/p5-Moose/distinfo,v
retrieving revision 1.13
diff -u -p -r1.13 distinfo
--- distinfo 22 Mar 2014 13:53:57 -0000 1.13
+++ distinfo 31 Jul 2020 02:55:32 -0000
@@ -1,2 +1,2 @@
-SHA256 (Moose-2.1204.tar.gz) = 9zQbjoAEvgoYqKFOSlqs+7OoiNt+M+CXkdPGEQVjHvc=
-SIZE (Moose-2.1204.tar.gz) = 776612
+SHA256 (Moose-2.2013.tar.gz) = 33TceAiJIReO33LYJwF9bJJzfJhmWfLa3FM64kZ153w=
+SIZE (Moose-2.2013.tar.gz) = 857254
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/devel/p5-Moose/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 12 Nov 2007 14:27:33 -0000 1.1.1.1
+++ pkg/DESCR 31 Jul 2020 02:55:32 -0000
@@ -1,4 +1,10 @@
-Moose is built on top of Class::MOP, which is a metaclass system
-for Perl 5. This means that Moose not only makes building normal
-Perl 5 objects better, but it also provides the power of metaclass
-programming.
+Moose is an extension of the Perl 5 object system.
+
+The main goal of Moose is to make Perl 5 Object Oriented programming
+easier, more consistent, and less tedious. With Moose you can think
+more about what you want to do and less about the mechanics of OOP.
+
+Additionally, Moose is built on top of Class::MOP, which is a
+metaclass system for Perl 5. This means that Moose not only makes
+building normal Perl 5 objects better, but it provides the power
+of metaclass programming as well.
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/p5-Moose/pkg/PLIST,v
retrieving revision 1.12
diff -u -p -r1.12 PLIST
--- pkg/PLIST 20 Mar 2015 22:47:40 -0000 1.12
+++ pkg/PLIST 31 Jul 2020 02:55:32 -0000
@@ -1,6 +1,6 @@
@comment $OpenBSD: PLIST,v 1.12 2015/03/20 22:47:40 naddy Exp $
@pkgpath devel/p5-Class-MOP
-bin/moose-outdated
+@comment bin/moose-outdated
${P5ARCH}/Class/MOP/
${P5ARCH}/Class/MOP.pm
${P5ARCH}/Class/MOP/Attribute.pm
@@ -17,7 +17,6 @@ ${P5ARCH}/Class/MOP/Method/Constructor.p
${P5ARCH}/Class/MOP/Method/Generated.pm
${P5ARCH}/Class/MOP/Method/Inlined.pm
${P5ARCH}/Class/MOP/Method/Meta.pm
-${P5ARCH}/Class/MOP/Method/Overload.pm
${P5ARCH}/Class/MOP/Method/Wrapped.pm
${P5ARCH}/Class/MOP/MiniTrait.pm
${P5ARCH}/Class/MOP/Mixin/
@@ -25,12 +24,14 @@ ${P5ARCH}/Class/MOP/Mixin.pm
${P5ARCH}/Class/MOP/Mixin/AttributeCore.pm
${P5ARCH}/Class/MOP/Mixin/HasAttributes.pm
${P5ARCH}/Class/MOP/Mixin/HasMethods.pm
+${P5ARCH}/Class/MOP/Mixin/HasOverloads.pm
${P5ARCH}/Class/MOP/Module.pm
${P5ARCH}/Class/MOP/Object.pm
+${P5ARCH}/Class/MOP/Overload.pm
${P5ARCH}/Class/MOP/Package.pm
${P5ARCH}/Moose/
${P5ARCH}/Moose.pm
-${P5ARCH}/Moose/Conflicts.pm
+@comment ${P5ARCH}/Moose/Conflicts.pm
${P5ARCH}/Moose/Cookbook/
${P5ARCH}/Moose/Cookbook.pod
${P5ARCH}/Moose/Cookbook/Basics/
@@ -180,6 +181,7 @@ ${P5ARCH}/Moose/Exception/InvalidBaseTyp
${P5ARCH}/Moose/Exception/InvalidHandleValue.pm
${P5ARCH}/Moose/Exception/InvalidHasProvidedInARole.pm
${P5ARCH}/Moose/Exception/InvalidNameForType.pm
+${P5ARCH}/Moose/Exception/InvalidOverloadOperator.pm
${P5ARCH}/Moose/Exception/InvalidRoleApplication.pm
${P5ARCH}/Moose/Exception/InvalidTypeConstraint.pm
${P5ARCH}/Moose/Exception/InvalidTypeGivenToCreateParameterizedTypeConstraint.pm
@@ -208,6 +210,7 @@ ${P5ARCH}/Moose/Exception/MethodNameNotF
${P5ARCH}/Moose/Exception/MethodNameNotGiven.pm
${P5ARCH}/Moose/Exception/MustDefineAMethodName.pm
${P5ARCH}/Moose/Exception/MustDefineAnAttributeName.pm
+${P5ARCH}/Moose/Exception/MustDefineAnOverloadOperator.pm
${P5ARCH}/Moose/Exception/MustHaveAtLeastOneValueToEnumerate.pm
${P5ARCH}/Moose/Exception/MustPassAHashOfOptions.pm
${P5ARCH}/Moose/Exception/MustPassAMooseMetaRoleInstanceOrSubclass.pm
@@ -240,6 +243,13 @@ ${P5ARCH}/Moose/Exception/NoImmutableTra
${P5ARCH}/Moose/Exception/NoParentGivenToSubtype.pm
${P5ARCH}/Moose/Exception/OnlyInstancesCanBeCloned.pm
${P5ARCH}/Moose/Exception/OperatorIsRequired.pm
+${P5ARCH}/Moose/Exception/OverloadConflictInSummation.pm
+${P5ARCH}/Moose/Exception/OverloadRequiresAMetaClass.pm
+${P5ARCH}/Moose/Exception/OverloadRequiresAMetaMethod.pm
+${P5ARCH}/Moose/Exception/OverloadRequiresAMetaOverload.pm
+${P5ARCH}/Moose/Exception/OverloadRequiresAMethodNameOrCoderef.pm
+${P5ARCH}/Moose/Exception/OverloadRequiresAnOperator.pm
+${P5ARCH}/Moose/Exception/OverloadRequiresNamesForCoderef.pm
${P5ARCH}/Moose/Exception/OverrideConflictInComposition.pm
${P5ARCH}/Moose/Exception/OverrideConflictInSummation.pm
${P5ARCH}/Moose/Exception/PackageDoesNotUseMooseExporter.pm
@@ -257,6 +267,7 @@ ${P5ARCH}/Moose/Exception/Role/Attribute
${P5ARCH}/Moose/Exception/Role/Class.pm
${P5ARCH}/Moose/Exception/Role/EitherAttributeOrAttributeName.pm
${P5ARCH}/Moose/Exception/Role/Instance.pm
+${P5ARCH}/Moose/Exception/Role/InstanceClass.pm
${P5ARCH}/Moose/Exception/Role/InvalidAttributeOptions.pm
${P5ARCH}/Moose/Exception/Role/Method.pm
${P5ARCH}/Moose/Exception/Role/ParamsHash.pm
@@ -268,7 +279,6 @@ ${P5ARCH}/Moose/Exception/RoleDoesTheExc
${P5ARCH}/Moose/Exception/RoleExclusionConflict.pm
${P5ARCH}/Moose/Exception/RoleNameRequired.pm
${P5ARCH}/Moose/Exception/RoleNameRequiredForMooseMetaRole.pm
-${P5ARCH}/Moose/Exception/RoleNamesDoNotMatch.pm
${P5ARCH}/Moose/Exception/RolesDoNotSupportAugment.pm
${P5ARCH}/Moose/Exception/RolesDoNotSupportExtends.pm
${P5ARCH}/Moose/Exception/RolesDoNotSupportInner.pm
@@ -279,7 +289,6 @@ ${P5ARCH}/Moose/Exception/SingleParamsTo
${P5ARCH}/Moose/Exception/TriggerMustBeACodeRef.pm
${P5ARCH}/Moose/Exception/TypeConstraintCannotBeUsedForAParameterizableType.pm
${P5ARCH}/Moose/Exception/TypeConstraintIsAlreadyCreated.pm
-${P5ARCH}/Moose/Exception/TypeNamesDoNotMatch.pm
${P5ARCH}/Moose/Exception/TypeParameterMustBeMooseMetaType.pm
${P5ARCH}/Moose/Exception/UnableToCanonicalizeHandles.pm
${P5ARCH}/Moose/Exception/UnableToCanonicalizeNonRolePackage.pm
@@ -310,6 +319,7 @@ ${P5ARCH}/Moose/Manual/FAQ.pod
${P5ARCH}/Moose/Manual/MOP.pod
${P5ARCH}/Moose/Manual/MethodModifiers.pod
${P5ARCH}/Moose/Manual/MooseX.pod
+${P5ARCH}/Moose/Manual/Resources.pod
${P5ARCH}/Moose/Manual/Roles.pod
${P5ARCH}/Moose/Manual/Support.pod
${P5ARCH}/Moose/Manual/Types.pod
@@ -472,7 +482,7 @@ ${P5ARCH}/Moose/Util/TypeConstraints/Bui
${P5ARCH}/Test/
${P5ARCH}/Test/Moose.pm
${P5ARCH}/auto/Moose/
-${P5ARCH}/auto/Moose/Moose.so
+@so ${P5ARCH}/auto/Moose/Moose.so
${P5ARCH}/metaclass.pm
${P5ARCH}/oose.pm
@man man/man3p/Class::MOP.3p
@@ -487,18 +497,18 @@ ${P5ARCH}/oose.pm
@man man/man3p/Class::MOP::Method::Generated.3p
@man man/man3p/Class::MOP::Method::Inlined.3p
@man man/man3p/Class::MOP::Method::Meta.3p
-@man man/man3p/Class::MOP::Method::Overload.3p
@man man/man3p/Class::MOP::Method::Wrapped.3p
@man man/man3p/Class::MOP::MiniTrait.3p
@man man/man3p/Class::MOP::Mixin.3p
@man man/man3p/Class::MOP::Mixin::AttributeCore.3p
@man man/man3p/Class::MOP::Mixin::HasAttributes.3p
@man man/man3p/Class::MOP::Mixin::HasMethods.3p
+@man man/man3p/Class::MOP::Mixin::HasOverloads.3p
@man man/man3p/Class::MOP::Module.3p
@man man/man3p/Class::MOP::Object.3p
+@man man/man3p/Class::MOP::Overload.3p
@man man/man3p/Class::MOP::Package.3p
@man man/man3p/Moose.3p
-@man man/man3p/Moose::Conflicts.3p
@man man/man3p/Moose::Cookbook.3p
@man
man/man3p/Moose::Cookbook::Basics::BankAccount_MethodModifiersAndSubclassing.3p
@man man/man3p/Moose::Cookbook::Basics::BinaryTree_AttributeFeatures.3p
@@ -547,6 +557,7 @@ ${P5ARCH}/oose.pm
@man man/man3p/Moose::Manual::MOP.3p
@man man/man3p/Moose::Manual::MethodModifiers.3p
@man man/man3p/Moose::Manual::MooseX.3p
+@man man/man3p/Moose::Manual::Resources.3p
@man man/man3p/Moose::Manual::Roles.3p
@man man/man3p/Moose::Manual::Support.3p
@man man/man3p/Moose::Manual::Types.3p
