On Mon, 10 Aug 2020, Bjorn Ketelaars wrote: > On Mon 10/08/2020 16:00, Paco Esteban wrote: > > Hi Bjorn, > > > > Comments inline. > > Other that those seems good to me. > > > > On Sun, 09 Aug 2020, Bjorn Ketelaars wrote: > > > > > FLAVORS = python3 > > > -FLAVOR ?= > > > +FLAVOR ?= python3 > > > > Shouldn't this be FLAVOR = python3 ?? > > bket@zeus:/usr/ports$ ag -l -G Makefile 'FLAVOR[| ]\?=.*python3' | wc -l > 23 > bket@zeus:/usr/ports$ ag -l -G Makefile 'FLAVOR[| ]\=.*python3' | wc -l > 107 > > FLAVOR=python3 is preferred. I will change to the latter before > committing. > > > > > +@conflict py-numexpr-* > > > +@pkgpath math/py-numexpr > > > > This is probably ok but I've seen (even committed myself) conflict lines > > both like you're doing and with `category/py-port-*`. Not sure which > > one is preferred (as they both seem to be ok). > > As sthen@ stated: @conflict-marker should be used without category/. > > OK?
ok paco@ -- Paco Esteban. 0x5818130B8A6DBC03
