On 08/18 05:17, Aaron Bieber wrote: > On Tue, 18 Aug 2020 at 15:41:16 -0700, Jeremy Evans wrote: > > On 08/18 04:17, Aaron Bieber wrote: > > > Hi Jeremy! > > > > > > Here is a diff tb@ was kind enough to smack together when I was trying to > > > track > > > down why TLS 1.3 was not available in ruby. > > > > > > I have tested on a few different machines with no ill effect. > > > > > > I also ran the tests which resulted in: > > > Finished tests in 1463.007495s, 14.3492 tests/s, 1858.9283 assertions/s. > > > 20993 tests, 2719626 assertions, 14 failures, 0 errors, 73 skips > > > > I'm OK adding this as long as it doesn't cause any regressions. > > > > What the results you are getting for the tests without this patch? I > > would expect some failures, as I know I've made changes to the ruby > > master branch to fix issues in OpenBSD-current, and those fixes would > > not be present in Ruby 2.7.1. However, if anything additional breaks, > > we need to investigate and determine if it is an issue with the tests > > or a regression that needs to be addressed. > > Results actually look better with the patch! > > Before: > > Finished tests in 896.442532s, 23.4204 tests/s, 3034.9296 assertions/s. > 20995 tests, 2720640 assertions, 16 failures, 0 errors, 78 skips
That's great. OK jeremy@. It's a good time to get this in as it will allow for testing before OpenBSD 6.8. Thanks, Jeremy
