Comments inline.

On Mon, Aug 17, 2020 at 07:04:12PM -0400, Sven F. wrote:
> Index: devel/p5-Struct-Dumb/Makefile
> ===================================================================
> RCS file: devel/p5-Struct-Dumb/Makefile
> diff -N devel/p5-Struct-Dumb/Makefile
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ devel/p5-Struct-Dumb/Makefile 17 Aug 2020 22:54:51 -0000
> @@ -0,0 +1,23 @@
> +# $OpenBSD$
> +
> +COMMENT= make simple lightweight record-like structures

I'm not sure if it's just the way this was submitted, but the proper
format here is optional space, operator (= or +=), tab.  Specifically,
the character after the = (or +=) should be a tab, not a space.

The optional space should be consistent in the file.


> +
> +MODULES= cpan
> +CPAN_AUTHOR= PEVANS
> +PKG_ARCH= *
> +DISTNAME= Struct-Dumb-0.12
> +CATEGORIES= devel

This is an odd order, The DISTNAME should be first and the others can
either go here or down by the CONFIGURE_STYLE.  No real preference on
that, but I think it's more common for them to be down below.



> +MAINTAINER= Sven <[email protected]>
> +
> +# perl
> +PERMIT_PACKAGE= Yes
> +
> +CONFIGURE_STYLE= modbuild tiny

This didn't work for me, it seems to want the full modbuild, not
the tiny version.


> +
> +BUILD_DEPENDS+= devel/p5-Test-Fatal
> +TEST_DEPENDS+= devel/p5-Test-Fatal

These should not be "+=" and the BUILD_DEPENDS isn't necessary, but it
does need an additional TEST_DEPENDS on devel/p5-Data-Dump and
devel/p5-Test-Pod though, because otherwise the test run could be
different if that's installed.

This particular module doesn't need the MAKE_ENV=TEST_POD=Yes since it
runs the pod tests if Test::Pod is installed.


> +.include <bsd.port.mk>
> +
> Index: devel/p5-Struct-Dumb/distinfo
> ===================================================================
> RCS file: devel/p5-Struct-Dumb/distinfo
> diff -N devel/p5-Struct-Dumb/distinfo
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ devel/p5-Struct-Dumb/distinfo 17 Aug 2020 22:54:51 -0000
> @@ -0,0 +1,2 @@
> +SHA256 (Struct-Dumb-0.12.tar.gz) = 
> Us5wxDPmlirRwg6eKXpTkeC3SkRSD7zi5IL1RONlf3M=
> +SIZE (Struct-Dumb-0.12.tar.gz) = 17513
> Index: devel/p5-Struct-Dumb/pkg/DESCR
> ===================================================================
> RCS file: devel/p5-Struct-Dumb/pkg/DESCR
> diff -N devel/p5-Struct-Dumb/pkg/DESCR
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ devel/p5-Struct-Dumb/pkg/DESCR 17 Aug 2020 22:54:51 -0000
> @@ -0,0 +1,7 @@
> +Struct::Dumb creates record-like structure types,
> +similar to the struct keyword in C, C++ or C#,
> +or Record in Pascal.
> +An invocation of this module will create a construction
> +function which returns new object references with the
> +given field values. These references all respond to
> +lvalue methods that access or modify the values stored.

The DESCR is generally considered normal text broken at 80 columns, not
any sort of markup so semantic line breaks are not commonly used.  I
don't know if there are specific guidelines on that, but the porting
guide does suggest running it through fmt(1).


> Index: devel/p5-Struct-Dumb/pkg/PLIST
> ===================================================================
> RCS file: devel/p5-Struct-Dumb/pkg/PLIST
> diff -N devel/p5-Struct-Dumb/pkg/PLIST
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ devel/p5-Struct-Dumb/pkg/PLIST 17 Aug 2020 22:54:51 -0000
> @@ -0,0 +1,4 @@
> +@comment $OpenBSD$
> +${P5SITE}/Struct/
> +${P5SITE}/Struct/Dumb.pm
> +@man man/man3p/Struct::Dumb.3p
> Index: databases/p5-Net-Prometheus/Makefile
> ===================================================================
> RCS file: databases/p5-Net-Prometheus/Makefile
> diff -N databases/p5-Net-Prometheus/Makefile
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ databases/p5-Net-Prometheus/Makefile 13 Aug 2020 00:12:44 -0000
> @@ -0,0 +1,25 @@
> +# $OpenBSD$
> +
> +COMMENT = export monitoring metrics for prometheus
> +
> +DISTNAME = Net-Prometheus-0.11
> +CATEGORIES = databases
> +
> +MAINTAINER = Sven <[email protected]>
> +
> +# Perl
> +PERMIT_PACKAGE = Yes
> +
> +MODULES = cpan
> +
> +CONFIGURE_STYLE = modbuild tiny

Like the other, this wants modbuild, not modbuild tiny for me.

> +
> +BUILD_DEPENDS+= devel/p5-Test-Fatal \
> + devel/p5-Ref-Util \
> + devel/p5-Struct-Dumb

Again, =, not += and tabs after not spaces.  Also, consistency is nice.
Either use the space before the operator or not.

These BUILD_DEPENDS are not necessary as they duplicate what is in the
RUN_DEPENDS and TEST_DEPENDS and none of the dependencies are required
during the BUILD phase.


> +TEST_DEPENDS += devel/p5-Test-Fatal

TEST_DEPENDS also needs www/p5-HTTP-Message

I would also like to see adding devel/p5-Test-Pod to TEST_DEPENDS here
so that test runs are consistent no matter what modules are installed
when you start.


> +RUN_DEPENDS += devel/p5-Ref-Util \
> + devel/p5-Struct-Dumb

RUN_DEPENDS needs www/p5-URI

Also, RUN_DEPENDS should come before TEST_DEPENDS as it is in
Makefile.template.


> +
> +.include <bsd.port.mk>
> Index: databases/p5-Net-Prometheus/distinfo
> ===================================================================
> RCS file: databases/p5-Net-Prometheus/distinfo
> diff -N databases/p5-Net-Prometheus/distinfo
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ databases/p5-Net-Prometheus/distinfo 13 Aug 2020 00:12:44 -0000
> @@ -0,0 +1,2 @@
> +SHA256 (Net-Prometheus-0.11.tar.gz) =
> IvgJ4njq1Rk2rVOVgGUbTOXLyRwgnkpXesgjg82fcmo=
> +SIZE (Net-Prometheus-0.11.tar.gz) = 39243
> Index: databases/p5-Net-Prometheus/pkg/DESCR
> ===================================================================
> RCS file: databases/p5-Net-Prometheus/pkg/DESCR
> diff -N databases/p5-Net-Prometheus/pkg/DESCR
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ databases/p5-Net-Prometheus/pkg/DESCR 13 Aug 2020 00:12:44 -0000
> @@ -0,0 +1,3 @@
> +This module provides the ability for a program to
> +collect monitoring metrics and export them to the
> +prometheus.io monitoring server.

Again, the wrapping is odd.


> Index: databases/p5-Net-Prometheus/pkg/PLIST
> ===================================================================
> RCS file: databases/p5-Net-Prometheus/pkg/PLIST
> diff -N databases/p5-Net-Prometheus/pkg/PLIST
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ databases/p5-Net-Prometheus/pkg/PLIST 13 Aug 2020 00:12:44 -0000
> @@ -0,0 +1,32 @@
> +@comment $OpenBSD$
> +${P5ARCH}/
> +${P5ARCH}/auto/
> +${P5ARCH}/auto/Net/
> +${P5ARCH}/auto/Net/Prometheus/
> +${P5ARCH}/auto/Net/Prometheus/PerlCollector/
> +${P5ARCH}/auto/Net/Prometheus/PerlCollector/PerlCollector.bs
> +${P5ARCH}/auto/Net/Prometheus/PerlCollector/PerlCollector.so
> +${P5ARCH}/Net/
> +${P5ARCH}/Net/Prometheus.pm
> +${P5ARCH}/Net/Prometheus/
> +${P5ARCH}/Net/Prometheus/Counter.pm
> +${P5ARCH}/Net/Prometheus/Gauge.pm
> +${P5ARCH}/Net/Prometheus/Histogram.pm
> +${P5ARCH}/Net/Prometheus/Metric.pm
> +${P5ARCH}/Net/Prometheus/PerlCollector.pm
> +${P5ARCH}/Net/Prometheus/ProcessCollector.pm
> +${P5ARCH}/Net/Prometheus/Registry.pm
> +${P5ARCH}/Net/Prometheus/Summary.pm
> +${P5ARCH}/Net/Prometheus/Types.pm
> +${P5ARCH}/Net/Prometheus/ProcessCollector/linux.pm
> +@man man/man3p/Net::Prometheus.3p
> +@man man/man3p/Net::Prometheus::Counter.3p
> +@man man/man3p/Net::Prometheus::Gauge.3p
> +@man man/man3p/Net::Prometheus::Histogram.3p
> +@man man/man3p/Net::Prometheus::Metric.3p
> +@man man/man3p/Net::Prometheus::PerlCollector.3p
> +@man man/man3p/Net::Prometheus::ProcessCollector.3p
> +@man man/man3p/Net::Prometheus::ProcessCollector::linux.3p
> +@man man/man3p/Net::Prometheus::Registry.3p
> +@man man/man3p/Net::Prometheus::Summary.3p
> +@man man/man3p/Net::Prometheus::Types.3p.

Is the trailing "." an artifact of how this was mailed?

For new ports a tarball is preferred over a patch against /dev/null.

l8rZ,
-- 
andrew - http://afresh1.com

Computer analyst to programmer:
               "You start coding. I'll go find out what they want."

Reply via email to