On Sun Aug 23, 2020 at 11:07:41PM +0100, Stuart Henderson wrote:
> On 2020/08/23 12:32, Asher Pasha wrote:
> > Hi ports@
> > Attached is a diff to update graphics/darktable to 3.2.1. I have
> > tested it on amd64. Here are the changes:
>
> tweaked version attached;
>
> > 1) port-lib-depends-check wanted net/flickcurl removed and
> > ${COMPILER_LIBSTDCXX} added to WANTLIB.
>
> there's no such thing as ${COMPILER_LIBSTDCXX}, also it picks up libavif
> if present at build time so that should either be disabled or added as
> LIB_DEPENDS/WANTLIB.
>
> > 2) OpenCL is turned off. Darktable sometimes crashes with OpenCL turned on.
> >
> > 3) ZLIB is turned off. OpenBSD has its own ZLIB, but Darktable
> > requires a newer version of ZLIB. The other option is to build ZLIB
> > bundled with Darktable, but then ZLIB didn't compile for me.
>
> the cmakefile checks for zlib 1.2.11, but if that check is removed it
> does still build and seems to run (it is able to open a DNG downloaded
> from a website that I threw at it, but I'm not sure if it uses deflate
> compression which is what zlib is used for here).
>
> > 4) CMakeLists.txt patch is added to remove _XOPEN_SOURCE.
> >
> > 5) If you upgrade to darktable 3+, ~/.config/darktable upgrades too.
> > However, it might not be possible to downgrade back to darktable 2
> > series without breaking ~/.config/darktable. I suggest backup
> > ~/.config/darktable before upgrading.
> >
> > 6) Support for newer cameras (such as the new mirrorless ones) needs
> > some more work. However, I was able to edit RAW sample images from one
> > of the newer cameras, but lens corrections were not available. I will
> > try to update graphics/lensfun and the lens corrections become
> > available.
> >
> > Thoughts? If ok, please commit.
> > Asher
>
> extract_wb_from_images.sh is only built if exiftool is available during
> build, I've added a dependency.
>
> does this still work for you?
>
Here too and also the raw-library update works. OK rsadowski@
