On Tue, Sep 08, 2020 at 07:20:55PM +0200, Theo Buehler wrote: > On Tue, Sep 08, 2020 at 07:07:37PM +0200, Frederic Cambus wrote: > > On Tue, Sep 08, 2020 at 11:43:04AM -0400, Kurt Mosiejczuk wrote: > > > The build of www/kore dies on sparc64 because of -Werror. > > > > > > Modifying the patch for Makefile removes that and fixes the build. > > > > > > ok? > > > > Could you please share the log showing the warnings? > > > > Just this: > > cc1: warnings being treated as errors > src/json.c: In function 'json_get_string': > src/json.c:783: warning: comparison is always true due to limited range of > data type > > ch is an u_int8_t, so 'ch >= 0' is always true.
Makes sense. It's indeed better to patch, OK fcambus@ for your diff. I pointed this out to joris@, the fix is now pushed upstream: https://github.com/jorisvink/kore/commit/f6af4a27f49d2fef33783066771fc0635288ecc5
