Hi bket@, Thanks for your review and advice.
All issues fixed with new attached file. On Thu, Sep 17, 2020 at 12:36 PM Bjorn Ketelaars <[email protected]> wrote: > On Thu 17/09/2020 00:25, Shawn Chiou wrote: > > Hi ports@, > > > > Attached is the port of lxterminal. It is a GTK based terminal emulator > of > > LXDE. > > > > Tested on amd64, also pass with portcheck -N. > > > > Any feedback is welcome. > > > Please use a complete email address with a real name for MAINTAINER. > Have a look at /usr/ports/infrastructure/templates/Makefile.template for > an example. > > Minor issue: use a tab after 'VARIABLE =' instead of a space. This > makes the Makefile more consistent. Have a look at BUILD_DEPENDS, > CONFIGURE_ARGS and CONFIGURE_STYLE, which use a space after '='. > > Builds and runs for me. > -- [image: --] Shawn Chiou [image: https://]about.me/shawn.chiou <https://about.me/shawn.chiou?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links>
lxterminal.tar.gz
Description: GNU Zip compressed data
