Hi,
Here are some test fixes for XML::Atom, spotted while reviewing the
DateTime::TimeZone update:
- [0] One test won't run if '.' is not in @INC
- [1] One test fails because XML::LibXML>=2.0202 does not expand
entities anymore
- While here, i have tweaked the Makefile:
- remove BUILD_DEPENDS=RUN_DEPENDS
- make spacing around '=' consistent
This causes no changes in the package, so no REVISION bump is needed.
Comments/feedback are welcome,
Charlène.
[0] https://github.com/miyagawa/xml-atom/issues/12
[1] https://github.com/miyagawa/xml-atom/issues/18
Index: Makefile
===================================================================
RCS file: /cvs/ports/www/p5-XML-Atom/Makefile,v
retrieving revision 1.15
diff -u -p -u -p -r1.15 Makefile
--- Makefile 3 Jul 2020 21:46:07 -0000 1.15
+++ Makefile 8 Oct 2020 10:39:00 -0000
@@ -1,18 +1,18 @@
# $OpenBSD: Makefile,v 1.15 2020/07/03 21:46:07 sthen Exp $
-COMMENT= Atom RSS protocol for perl
+COMMENT = Atom RSS protocol for perl
-MODULES= cpan
-PKG_ARCH= *
+MODULES = cpan
+PKG_ARCH = *
DISTNAME = XML-Atom-0.42
-CATEGORIES= www textproc
+CATEGORIES = www textproc
REVISION = 0
-# perl
-PERMIT_PACKAGE= Yes
+# Perl
+PERMIT_PACKAGE = Yes
-RUN_DEPENDS= devel/p5-Class-Data-Inheritable \
+RUN_DEPENDS = devel/p5-Class-Data-Inheritable \
devel/p5-DateTime \
devel/p5-DateTime-TimeZone \
security/p5-Digest-SHA1 \
@@ -21,7 +21,6 @@ RUN_DEPENDS= devel/p5-Class-Data-Inherit
www/p5-HTML-Parser \
www/p5-LWP-Authen-Wsse \
www/p5-libwww
-BUILD_DEPENDS= ${RUN_DEPENDS}
CONFIGURE_STYLE = modbuild tiny
Index: patches/patch-t_11-entry_t
===================================================================
RCS file: patches/patch-t_11-entry_t
diff -N patches/patch-t_11-entry_t
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-t_11-entry_t 8 Oct 2020 10:39:00 -0000
@@ -0,0 +1,15 @@
+$OpenBSD$
+
+See https://github.com/miyagawa/xml-atom/issues/12
+
+Index: t/11-entry.t
+--- t/11-entry.t.orig
++++ t/11-entry.t
+@@ -2,6 +2,7 @@
+
+ use strict;
+
++use lib '.';
+ use t::TestLib;
+ use Test::More;
+ use XML::Atom;
Index: patches/patch-t_31-external-entities-libxml_t
===================================================================
RCS file: patches/patch-t_31-external-entities-libxml_t
diff -N patches/patch-t_31-external-entities-libxml_t
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-t_31-external-entities-libxml_t 8 Oct 2020 10:39:00
-0000
@@ -0,0 +1,15 @@
+$OpenBSD$
+
+See https://github.com/miyagawa/xml-atom/issues/18
+
+Index: t/31-external-entities-libxml.t
+--- t/31-external-entities-libxml.t.orig
++++ t/31-external-entities-libxml.t
+@@ -51,6 +51,7 @@ EOX
+ ## custom parser
+ {
+ my $libxml = XML::LibXML->new;
++ $libxml->expand_entities(1);
+ my $entry = XML::Atom::Entry->new(Stream => \$xml, Parser => $libxml);
+ is $entry->title, "Guest Author", "got title";
+ my $content = $entry->content->body;