Relating to the port:
- the various ${PROGNAME} in Makefile are quite awkward, prefer just 'pftbld'
- looks like there should be an "@sample ${SYSCONFDIR}/pftbld.conf" after
the pftbld.conf entry in plist
Relating to pftbld itself:
- tinypfctl.c is a binding to PF ABI. while there are a few other things
which do this in ports, many of them are broken or have been broken
for quite long times in the past due to PF changes. I think it's not
an absolute show-stopper as long as you plan to track OpenBSD -current
and keep it updated and let us know if REVISION bumps are needed due
to changes in PF structs (ABI), or make changes as needed for API changes,
but generally it's preferred to interface by calling the pfctl(8) binary
instead, that way it would be decoupled from PF ABI/API.
On 2020/10/13 14:05, [email protected] wrote:
> Ping. Latest tarball attached.
>
>
> On 2020-10-06 16:14, [email protected] wrote:
> > Ping. Updated archive attached.
> >
> >
> > On 2020-09-16 13:39, [email protected] wrote:
> >> Any comments/OKs/commits are welcome.
> >>
> >>
> >> Index: infrastructure/db/user.list
> >> ===================================================================
> >> RCS file: /cvs/ports/infrastructure/db/user.list,v
> >> retrieving revision 1.375
> >> diff -u -p -u -p -r1.375 user.list
> >> --- infrastructure/db/user.list 12 Sep 2020 15:33:51 -0000 1.375
> >> +++ infrastructure/db/user.list 16 Sep 2020 11:07:04 -0000
> >> @@ -368,3 +368,4 @@ id user group port
> >> 857 _web2ldap _web2ldap sysutils/web2ldap
> >> 858 _purritobin _purritobin www/purritobin
> >> 859 _miniflux _miniflux net/miniflux
> >> +860 _pftbld _pftbld net/pftbld
> >> Index: net/Makefile
> >> ===================================================================
> >> RCS file: /cvs/ports/net/Makefile,v
> >> retrieving revision 1.1222
> >> diff -u -p -u -p -r1.1222 Makefile
> >> --- net/Makefile 12 Sep 2020 15:33:31 -0000 1.1222
> >> +++ net/Makefile 16 Sep 2020 11:07:04 -0000
> >> @@ -513,6 +513,7 @@
> >> SUBDIR += pear-Services-oEmbed
> >> SUBDIR += pen
> >> SUBDIR += pfstat
> >> + SUBDIR += pftbld
> >> SUBDIR += php-weathermap
> >> SUBDIR += pidgin
> >> SUBDIR += pidgin,gtkspell
