Wietse Venema:
> Tomoyuki Murakami:
> > I'm currently making a trial of postscreen DROP action.
> > DROP action is useful for reducing cost of tests, especially
> > skipping DNSBL checks are meaningful.
> > OTOH, we sometimes need SMTP envelope info to make statistics
> > later. the DROP action may also drops the chance of collecting
> > these info.
> 
> The ENFORCE action was implemented for exactly this purpose.
> 
> What is the benefit of skipping the other checks?

Comments on the code:

1) Your patch dynamically sets a global variable. Therefore it will
unexpectedly change postscreen behavior for other client sessions.

2) You can avoid a lot of source code changes by putting the new
code inside the DROP_SESSION macro.

3) Postscreeen never resets TODO flags, and I'm sure that there is
code that depends on this invariant.  To disable tests that are
already in progress, postscreen uses SKIP flags.

        Wietse

Reply via email to