On 02/12/2015 04:41 PM, Wietse Venema wrote:
Viktor Dukhovni:
On Wed, Feb 11, 2015 at 06:17:13PM -0800, Corey Ashford wrote:
From our reading of the code, tag can never be 0 there, so that makes the
"then" part of the if statement dead code.
After that, there's another if statement (line 254) that will always
evaluate as true:
if (tag != 0) {
...
In summary, I believe that removing the "tag = 0;" line was not the right
fix for the seg fault bug, but it's not clear to me what the right fix is.
Thank you Wietse, this is a very thorough analysis and a nice patch. I
appreciate your looking into this issue and coming up with this
solution. We will incorporate your patch into our private build of postfix.
Cheers,
- Corey
