On 2025-06-08 16:16:59-04:00, Wietse Venema via Postfix-devel wrote:
> - postconf_dbms.c needs to be updated to skip leading debug: prefixes
> just like proxy: prefixes. The purpose of that module is to
> inspect database-specific config files (LDAP, SQL, etc.), and
> to complain about mistakes with database client parameter settings.
Done, though I had some difficulty understanding the associated tests (I *think*
the tests I touched are the right ones anyway). v3 introduces a new patch (the
first patch in this two-patch series) to hopefully improve the existing tests.
The tests are then extended in the second patch to cover the new debug: feature.
Please let me know what you think.
I left a TODO comment in the second patch questioning whether $db:$name tables
inside unionmap: and pipemap: table names should also be handled there. Please
let me know if my understanding of that code is off.
> - Need to add ${SHLIB_ENV} before ${VALGRIND} in tests, so that
> they will work when Postfix is built with shared libpostfix-*
> libraries.
That was already in place in the Makefile. I can move it to the shell script,
but that gets a bit awkward with the .ref file and `set +x`. (The same is true
for ${VALGRIND}, but I figured that Valgrind is manually run so the .ref
mismatch isn't a big deal. Let me know if I should refactor to move ${VALGRIND}
out of the shell script.)
Changes since v2:
* Revamp the proxy: skip tests.
* Also skip over debug: in postconf_dbms.c, and update the skip tests.
* Use the DICT_TYPE_DEBUG macro consistently (instead of the string literal
"debug").
* Minor comment tweaks.
The new patches will be sent as replies to this email.
Thanks,
Richard
Richard Hansen (2):
postconf: Revamp table variable tests for readability, coverage
New "debug:" table/dict/map/db type for logging table accesses
proto/DATABASE_README.html | 13 ++++
src/postconf/Makefile.in | 41 +++----------
src/postconf/postconf.c | 10 ++++
src/postconf/postconf_dbms.c | 12 +++-
src/postconf/test28-main.cf | 34 +++++++++++
src/postconf/test28-master.cf | 2 +
src/postconf/test28.ref | 17 ++++--
src/postconf/test29-main.cf | 109 ++++++++++++++++++++++++++++++++++
src/postconf/test29.ref | 85 ++++++++++++++++++++------
src/proxymap/Makefile.in | 1 +
src/proxymap/proxymap.c | 2 +
src/util/Makefile.in | 12 +++-
src/util/dict_debug.c | 73 +++++++++++++++++++++--
src/util/dict_debug.h | 34 +++++++++++
src/util/dict_debug_test.ref | 51 ++++++++++++++++
src/util/dict_debug_test.sh | 25 ++++++++
src/util/dict_open.c | 2 +
17 files changed, 457 insertions(+), 66 deletions(-)
create mode 100644 src/postconf/test28-main.cf
create mode 100644 src/postconf/test28-master.cf
create mode 100644 src/postconf/test29-main.cf
create mode 100644 src/util/dict_debug.h
create mode 100644 src/util/dict_debug_test.ref
create mode 100755 src/util/dict_debug_test.sh
--
2.49.0
_______________________________________________
Postfix-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
