Richard Hansen via Postfix-devel:
> >> The patch is adopted.
> >
> > And reverted, because every Postfix .h file is included
> > after the .c file has already included <sys_defs.h>.
>
> The story behind this patch: I am working on another feature that I want
> to propose to you and the rest of the community when the PoC is ready.
> This new feature involves new .h and .c files. I ran into compiler
> errors because my personal coding habit is to include the corresponding
> .h at the top of the .c file, and the new .h file includes argv.h and
> vstream.h (indirectly). I didn't expect this patch to be controversial,
> so I didn't include more rationale in the commit message.
>
> For a new foo.c file, would you prefer its `#include "foo.h"` line to be
> mixed in with the other Postfix includes for consistency with the
> existing codebase? My personal preference is to put it at the top, but
> there's a lot of value in consistency, and I want to follow the style
> you prefer.
To be accepted into Postfix, make your code concistent with Postfix
convention. Thus, every .c file includes sys_defs.h first. No bypassing
Postfix libraries with direct malloc() calls and so on.
Wietse
_______________________________________________
Postfix-devel mailing list -- postfix-devel@postfix.org
To unsubscribe send an email to postfix-devel-le...@postfix.org
