On Sun, 2011-02-27 at 20:44:36 +0100, Matthias Andree wrote: > Am 27.02.2011 20:41, schrieb Sahil Tandon: > > On Sun, 2011-02-27 at 18:33:39 +0100, Matthias Andree wrote: > > > >> Am 26.02.2011 00:52, schrieb Sahil Tandon: > >>> On Fri, 2011-02-25 at 10:50:45 +0100, kristof.vans...@telenet.be wrote: > >>> > >>>> This problem exist in the 2.7 and 2.8 branch: > >>>> > >>>> In file included from attr_clnt.c:77: > >>>> /usr/include/unistd.h:329: error: conflicting types for 'closefrom' > >>>> ./sys_defs.h:1399: error: previous declaration of 'closefrom' was here > >>>> *** Error code 1 > >>>> > >>>> Stop in /home/src/postfix-2.7.2/src/util. > >>>> *** Error code 1 > >>>> > >>>> Stop in /home/src/postfix-2.7.2. > >>> > >>> Ah, you are not using the ports infrastructure, in which sys_defs.h has > >>> been patched to be aware of the closefrom() system call in 702104 and > >>> other FreeBSD versions. > >>> > >>> FWIW, this issue was discussed[1] on -devel a few months ago. > >> > >> Maybe, but pulling the patch into the upstream sources would seem right > >> to put this refinement where it belongs, no? > > > > I do not understand your response. "Maybe" what? The patch for > > upstream has already been proposed in the link I pasted earlier in this > > thread. So, naturally, I agree that upstream is the correct place for > > this "refinement". When some iteration of it is incorporated by Wietse, > > we'll just remove it from ports. > > Yeah. The simplest thing would be ditching FreeBSD 7.1 support (FreeBSD > 7.1 will be discontinued after tomorrow).
Agreed; but for the record, the patch we use in ports does not break the build on my RELENG_7_1 virtual machine. -- Sahil Tandon <sa...@freebsd.org>
