Someone should verify that all unit tests verify both "good input"
and "bad input" cases. Here, a "bad input" check was missing.
Wietse
Viktor Dukhovni:
> On Wed, Sep 30, 2015 at 10:05:12AM +0200, Krzysztof Wojta? wrote:
>
> > In version 2.x there was no error.
>
> The patch should also be applied to 2.11. Not just 3.x.
>
> > diff --git a/src/global/xtext.c b/src/global/xtext.c
> > index e5605d7..750f2dd 100644
> > --- a/src/global/xtext.c
> > +++ b/src/global/xtext.c
> > @@ -134,8 +134,7 @@ VSTRING *xtext_unquote_append(VSTRING *unquoted,
> > const char *quoted)
> > VSTRING *xtext_unquote(VSTRING *unquoted, const char *quoted)
> > {
> > VSTRING_RESET(unquoted);
> > - xtext_unquote_append(unquoted, quoted);
> > - return (unquoted);
> > + return xtext_unquote_append(unquoted, quoted) ? (unquoted) : (0);
> > }
>
> --
> Viktor.
>
