Andreas Thienemann:
> Looks good to me. Patched, rebuilt, verified working.
>
> Multiline responses from the milter are now correctly forwarded the smtpd
> and the client does not timeout anymore waiting for data.
>
> I do not know if skipping the printable() call does have any side-effects
> though.
As a short-term fix it is probably OK, because the cleanup daemon
already filters the response. But smtpd should not rely on the
cleanup server doing that.
A longer-term solution should enforce the single-line form (with
the existing printable(foo, ' ') call) by default, and allow
properly-formatted SMTP when SMTP is allowed. This way, proper
operation of the SMTP daemon won't be affected when the cleanup
daemon is borked. This is basic error containment.
Wietse
