Re: [PATCH 2/3] Fix parallel build dependencies

[Wietse Venema]

Christian G?ttsche:
> On Wed, 22 Dec 2021 at 22:21, Wietse Venema <wie...@porcupine.org> wrote:
> >
> > Christian G?ttsche:
> > > Plugin shared util objects require the global util object to be build.
> > >
> > What was the make command?
> 
> /usr/bin/make -j2 LD_LIBRARY_PATH=$(pwd)/lib:${LD_LIBRARY_PATH}
> 
> see https://salsa.debian.org/cgzones/postfix-dev/-/jobs/2304623/raw
> for a failed build log

The bug is that you're linking Postfix database plugins with
libpostfix-util or libpostfix-global. That is not supported.

You have:

    AUXLIBS_CDB="-lcdb -L../../lib -L. -lpostfix-util" \
    AUXLIBS_LDAP="-lldap -llber -L../../lib -L. -lpostfix-util 
-lpostfix-global" \
    AUXLIBS_LMDB="-llmdb -L../../lib -L. -lpostfix-util" \
    AUXLIBS_MYSQL="-lmysqlclient -L../../lib -L. -lpostfix-util 
-lpostfix-global" \
    AUXLIBS_PCRE="-lpcre -L../../lib -L. -lpostfix-util" \
    AUXLIBS_PGSQL="-lpq -L../../lib -L. -lpostfix-util -lpostfix-global" \
    AUXLIBS_SQLITE="-lsqlite3 -L../../lib -L. -lpostfix-util -lpostfix-global 
-lpthread" \

You should have:

    AUXLIBS_CDB="-lcdb"
    AUXLIBS_LDAP="-lldap -llber"
    AUXLIBS_LMDB="-llmdb"
    AUXLIBS_MYSQL="-lmysqlclient"
    AUXLIBS_PCRE="-lpcre"
    AUXLIBS_PGSQL="-lpq"
    AUXLIBS_SQLITE="-lsqlite3"

Also the following is unnecessary:

    make -j2 LD_LIBRARY_PATH=$(pwd)/lib:${LD_LIBRARY_PATH}

Instead, remove the LD_LIBRARY_PATH stuff do this:

    make -j2

I'll add a check to makedefs to fail the build with an UNSUPPORTED
error if it sees that database plugins are linked with libpostfix-*.

I'll also fix the makedefs check to reject LD_LIBRARY_PATH settings.

        Wietse