#4388: Memory leak - previousState -----------------------+---------------------------------------------------- Reporter: Richard | Owner: potlatch-dev@… Type: defect | Status: new Priority: critical | Milestone: Component: potlatch2 | Version: Keywords: | -----------------------+---------------------------------------------------- Each ControllerState has a previousState property.
This is a significant memory leak, as it means that controllerStates are never garbage-collected: there's always a previousState reference from the next one, which in turn has a reference from the next one, and so on. previousState is only actually used by DragBackground (to resume the previous state afterwards), so we should make this an instance variable for DragBackground only, and make sure it is nuked on exitState. As maintainer I hereby abuse my privileges to log this as 'critical', but mostly with the understanding that I am volunteering to fix it and this is mostly an aide-memoire. :) -- Ticket URL: <https://trac.openstreetmap.org/ticket/4388> OpenStreetMap <http://www.openstreetmap.org/> OpenStreetMap is a free editable map of the whole world _______________________________________________ Potlatch-dev mailing list Potlatch-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/potlatch-dev