Hi,

With the ALPM patches I get: Unable to set link PM policy.
[until now I've tested only the combination of your, and Tejun's
port-stopping patch, as I already reported in a past thread]
It looks like my device doesn't support hipm, however it supports dipm.
If I make the change below, the ALPM patches work (i.e. no errors,
~0.5W and power savings).
Do you see any problems with enabling alpm on devices supporting dipm
but not hipm?

Thanks,
Edwin

diff -u 2.6-git/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
--- 2.6-git/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2021,7 +2021,7 @@
       if (dev->flags & ATA_DFLAG_LBA48)
               dev->max_sectors = ATA_MAX_SECTORS_LBA48;

-       if (ata_id_has_hipm(dev->id))
+       if (ata_id_has_hipm(dev->id) || ata_id_has_dipm(dev->id))
               dev->flags |= ATA_DFLAG_IPM;
       if (dev->horkage & ATA_HORKAGE_DIAGNOSTIC) {
_______________________________________________
Power mailing list
[email protected]
http://www.bughost.org/mailman/listinfo/power

Reply via email to