Kok, Auke wrote: > Those features should IMHO be enabled by default in any case. > > I would almost suggest sending a patch upstream to enable these features by > default. If there is a good reason to _not_ do this, then I'm sure you'll hear > that from the maintainers. I personally do not know these drivers nor hardware > well enough.
Auke, Instead of sending a patch I asked for opinions on the netdev mailing list[1]. I was told by Ben Hutchings that as of 2.6.27 GSO is enabled by default for devices that can do TX scatter/gather and checksum offload. Rick Jones also commented that if a driver has a feature that isn't enabled by default, the implication is that that feature is not yet ready for regular use. So I guess that the netdev folks would argue against powertop suggesting to enable Ethernet offload features. Arjan's expectation that the gains would be small further undermines the case. [1]: http://marc.info/?l=linux-netdev&m=122902098115196&w=2 Thanks and best regards, Jan _______________________________________________ Power mailing list [email protected] http://www.bughost.org/mailman/listinfo/power
