On 4/27/2012 4:19 PM, Mike Frysinger wrote: > On Friday 27 April 2012 16:43:11 Arjan van de Ven wrote: >> On 4/27/2012 1:44 PM, Mike Frysinger wrote: >>> On Friday 27 April 2012 16:34:53 Sergey Senozhatsky wrote: >>>> iw: handle HAVE_LIBNL20 properly >>>> >>>> Move HAVE_CONFIG_H and config.h inclusion to iw header file, which is >>>> the right place for HAVE_LIBNL20 dependent `define nl_sock nl_handle'. >>> >>> glancing through the libnl headers, it seems we don't even need to manage >>> HAVE_LIBNL20 in autoconf. we can include netlink/version.h and key off >>> of LIBNL_VER_MAJ. >> >> one thing to note is that the iw.c code is borrowed from elsewhere... >> >> the more we deviate, the harder it will be to follow the other code >> (not that we needed to so far) > > hmm, no biggie. the file is small, and my suggestion isn't critical, so > keeping current stuff is ok.
if we're really improving it we should send the patches also to the maintainer at least.. _______________________________________________ Power mailing list Power@bughost.org https://bughost.org/mailman/listinfo/power
