On Sat 17. Dec - 11:01:38, Michael Biebl wrote:
> Hi,
> 
> I finally found the culprit which caused the strange behaviour under
> Debian. In Debian awk is installed under /usr/bin, so the parsing of the
> commandline at the end of the script helper_functions fails and as a
> consequence scripts/notify returns the wrong EVENT_TYPE on a
> battery.warning message. This causes powersaved to generate an
> Notification and because of the failed parsing the EVENT_TYPE is empty.
> awk_path.diff fixes this, it is made against the current SVN.

Great debugging ;-) Patch looks good.

> 
> About the su issue under gentoo, please don't use the patch I sent in my
>  previous email, but the su.diff file I attached to this email.

This is also the better way on SUSE distributions since 10.0 but should be
no problem with older releases IMO. Thanks for the patch.

> 
> Finally my modifications to wttyhx (missing -n under !SUSE distros, path
> to Xorg under Gentoo) in the wttyhx.diff patch. Would it have any ill
> effects under SUSE if the -n switch is removed?

No problem removing the -n switch. Adding /usr/bin/Xorg to the search path
is a good idea, too ;-)

> 
> I also noticed that the path to xmessage in x_helper_functions is
> hardcoded to /usr/X11R6/bin/xmessage. This is unsafe, as I mentioned in
> my previous post the new modular Xorg will abandon /usr/X11R6.
> Either use no absolute path at all or something like the following:
> XMESSAGE_BIN=/usr/X11R6/bin/xmessage
> [ -x "$XMESSAGE_BIN" ] || XMESSAGE="/usr/bin/xmessage"

I already fixed many hardcoded paths, but it seems that I have overseen
this one ;) Will change that.

Thanks again for your help,
       Holger
_______________________________________________
powersave-devel mailing list
[email protected]
http://forge.novell.com/mailman/listinfo/powersave-devel

Reply via email to