Holger Macht wrote: > On Thu 02. Mar - 02:20:24, Michael Biebl wrote: >> Looking through the powersave*.h header files I noticed that >> powersave_hal.h exposes the hal API by including <hal/libhal.h> although >> it is not needed (powersave_hal.h does not contain structs or the like >> defined in <hal/libhal.h>. AFAICT it should be removed. > > It surely uses libhal. For instance the function > LibHalContext* ps_hal_context(void);
You are right on this too. I must have overlooked it because it was too late yesterday. But why don't you also include dbus.h then, as you are obviously using DBusError* ps_hal_dbus_error(void); in powersave_hal.h? Am I missing something this time too? As it seems that HAL (and probably dbus) are not solely required internally but also exposed through powersave_hal.h, you should adapt powersave-dbus.pc.in accordingly: "Requires.private: dbus-1 hal" should be "Requires: dbus-1 hal" Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
_______________________________________________ powersave-devel mailing list [email protected] http://forge.novell.com/mailman/listinfo/powersave-devel
