Am Mittwoch, 23. August 2006 14:48 schrieb Holger Macht:
> On Mon 21. Aug - 13:42:57, Frank Seidel wrote:
> > Hi,
> >
> > for getting more HAL-support to kpowersave i've extended
> > Holgers first suggested patch for kpowersave (supporting
> > the new CPUFreq addon in HAL) to also do suspending
> > via DBus calls to HAL.
>
> Great, thanks. Finally we get some progress here...
You're welcome :)
> > [...]
> > Index: src/dbusPowersave.h
> > ===================================================================
> > --- src/dbusPowersave.h (Revision 2409)
> > +++ src/dbusPowersave.h (Arbeitskopie)
> > @@ -94,6 +94,12 @@
> > //! default destructor
> > ~dbusPowersaveConnection();
> >
> > + //!send a message with one argument to HAL
> > + static bool dbusSendHalMessage(char *method, int dbus_type, void
*arg);
> > +
> > + //!send a message with no/void argument to HAL
> > + static bool dbusSendVoidHalMessage(char *method);
> > +
>
> Frank, you told me that you are working on some generic helper
> functions. Does this have something to do with these dbus methods? I've
> got some functions floating around which are more generic to send dbus
> messages.
Yes, but i meant a newer version of this patch, not yet ready to post here.
I added another function for querying HAL device properties. Currently i
don't think much more will be needed here (at least by myself) and i wanted
to keep those helpers really simple in its usage.
Hopefully i will be able to post a newer version with some more additions here
today or tomorrow.
> > [...]
> > + if (!(result =
dbus_conn->dbusSendHalMessage("SetCPUFreqGovernor",
> >
+ DBUS_TYPE_STRING,
> >
+ (char*)"ondeman")))
>
>
^
> Missing 'd'. Don't know if that was already in in my initial patch.
No, it seems i somehow introduced this. Sorry ;) I fixed this one
> > [...]
> Can you please split up the patches into logical items next time? For
> example CPUFreq one part, Suspend via Hal another one.
Ok, i admit this is hard to read otherwise.
> Another thing: To get something going in this area, can you please create
> a branch like branches/kpowersave/kpowersave-ng (feel free to chose a more
> apropriate name), so that we can work together on the new branch and can
> start committing. The first commits haven't to be perfect, we can do
> cleanups later.
Are you sure about this step? I wouldn't like to create a seperate branch
for this if we could get this - of course with some rework - directly into
trunk.
Danny, what do you think?
Greetings,
Frank
--
----------------------------------------------------------------
Dipl.-Inf. (FH) Frank Seidel - Software Engineer Mobile Devices
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
Tel.: +49 (0) 911 / 74053 - 468 Email: [EMAIL PROTECTED]
----------------------------------------------------------------
--
----------------------------------------------------------------
Dipl.-Inf. (FH) Frank Seidel - Software Engineer Mobile Devices
SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
Tel.: +49 (0) 911 / 74053 - 468 Email: [EMAIL PROTECTED]
----------------------------------------------------------------
_______________________________________________
powersave-devel mailing list
[email protected]
http://forge.novell.com/mailman/listinfo/powersave-devel
