On Mon 28. Jan - 18:20:52, Michael Biebl wrote: > Holger Macht wrote: >> On Fri 25. Jan - 07:42:15, Michael Biebl wrote: >>> Michael Biebl wrote: >>>> A patch which fixes that and uses the new hal policy names, is attached. >>> I found another issue: The build failed, as liblazy_hal_get_property_int >>> in daemon/brightness.cpp uses char* not const char*. >>> >>> The attached patch fixes that and makes powersave 0.15.9 compile against >>> liblazy 0.2 [1]. >>> >>> On the other hand, in the current git repo [2], the method signatures >>> have been changed. If this patch isn't applied, would you consider >>> releasing a liblazy 0.2.1 version? >> >> My liblazy from [1] includes >> >> int liblazy_hal_get_property_int(const char *udi, const char *property, >> int *value); >> >> which seems to be correct. > > This is really weird. The copy of liblazy I have is dated from 2.11.07, the > one at [1] is from 21.11.07. Have you maybe re-released the 0.2 tarball > after [2] without bumping the version number? > Can you shed some light on this?
No, I did not release the tarball twice. However, I forgot to "push" some changes included in 0.2 into the git repository in the first place. So the repository was a little bit behind before I noticed. Maybe that could be the reason? Because freedesktop.org has no file release system, we can't find out anymore. Anyway, sorry for the inconvenience. May be this was just done by accident, I don't know. > >>> >>> [1] http://people.freedesktop.org/~homac/liblazy/liblazy-0.2.tar.bz2 >>> [2] >>> http://cgit.freedesktop.org/liblazy/diff/?id=5b5472187012670ff520707f70cf2c24658878be >> >>> Index: daemon/brightness.cpp >>> =================================================================== >>> --- daemon/brightness.cpp (Revision 1048) >>> +++ daemon/brightness.cpp (Arbeitskopie) >>> @@ -142,7 +142,7 @@ >>> if (!_supported) >>> return -1; >>> - const char *prop = "laptop_panel.num_levels"; >>> + char *prop = "laptop_panel.num_levels"; >> >> Are you sure that daemon/brightness.cpp doesn't use const char*? It does >> here. > > Yes, powersave 0.15.9 does use const char*. But as it didn't compile with > (the version I have of) liblazy 0.2, this would have been one way to fix > it. > As obviously the method signatures in liblazy are to be used with const > char *, this patch becomes obsolete. Thanks, Holger _______________________________________________ powersave-devel mailing list powersave-devel@forge.novell.com http://forge.novell.com/mailman/listinfo/powersave-devel
