Github user spodkowinski commented on the pull request:
https://github.com/apache/cassandra/commit/ba09523de7cad3b3732c0e7e60b072f84e809e21#commitcomment-28013514
In src/java/org/apache/cassandra/dht/BootstrapEvent.java:
In src/java/org/apache/cassandra/dht/BootstrapEvent.java on line 62:
It probably depends on how instances of Events classes will be handled. My
bet would be that people would add Events member instances as statics again, to
save some garbage and because they are stateless anyways. And if you look at
BootStrapper and would make bootstrapEvents static, why would that be wrong, if
you think about it outside the context of a broader singletons-are-evil
discussion?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
