Github user zznate commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/205#discussion_r173958314
  
    --- Diff: 
src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java ---
    @@ -267,12 +267,18 @@ public boolean updatesRegularRows()
             // columns is if we set some static columns, and in that case no 
clustering
             // columns should be given. So in practice, it's enough to check 
if we have
             // either the table has no clustering or if it has at least one of 
them set.
    -        return metadata().clusteringColumns().isEmpty() || 
restrictions.hasClusteringColumnsRestrictions();
    +        return !metadata().isVirtual() &&
    --- End diff --
    
    nit: why use the method if we have it locally (and it's public anyhoo). The 
object reference is being used elsewhere herein already. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to