Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/224#discussion_r187474479
  
    --- Diff: src/java/org/apache/cassandra/db/ReadCommand.java ---
    @@ -128,6 +130,7 @@ protected ReadCommand(Kind kind,
     
         protected abstract void serializeSelection(DataOutputPlus out, int 
version) throws IOException;
         protected abstract long selectionSerializedSize(int version);
    +    public abstract Replica decorateEndpoint(InetAddressAndPort endpoint);
    --- End diff --
    
    I'm not sure if this is a good idea based on it being used after we have 
already committed to that endpoint replicating a specific range a specific way. 
This seems like it races with ring changes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to