Github user aweisberg commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/224#discussion_r187715019
--- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java ---
@@ -176,25 +179,28 @@ public void addSourceFilter(ISourceFilter filter)
* Add ranges to be streamed for given keyspace.
*
* @param keyspaceName keyspace name
- * @param ranges ranges to be streamed
+ * @param replicas ranges to be streamed
*/
- public void addRanges(String keyspaceName, Collection<Range<Token>>
ranges)
+ public void addRanges(String keyspaceName, Replicas replicas)
{
if(Keyspace.open(keyspaceName).getReplicationStrategy() instanceof
LocalStrategy)
{
logger.info("Not adding ranges for Local Strategy
keyspace={}", keyspaceName);
return;
}
+ Replicas.checkFull(replicas);
+
boolean useStrictSource = useStrictSourcesForRanges(keyspaceName);
- Multimap<Range<Token>, InetAddressAndPort> rangesForKeyspace =
useStrictSource
- ? getAllRangesWithStrictSourcesFor(keyspaceName, ranges) :
getAllRangesWithSourcesFor(keyspaceName, ranges);
+ ReplicaMultimap<Range<Token>, ReplicaList> rangesForKeyspace =
useStrictSource
+ ?
getAllRangesWithStrictSourcesFor(keyspaceName, replicas.fullRanges())
--- End diff --
fullRanges(), not a fan.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
