Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r201468753
  
    --- Diff: 
src/java/org/apache/cassandra/net/async/RebufferingByteBufDataInputPlus.java ---
    @@ -249,4 +253,50 @@ public ByteBufAllocator getAllocator()
         {
             return channelConfig.getAllocator();
         }
    +
    +    /**
    +     * Consumes bytes in the stream until the given length
    +     *
    +     * @param writer
    +     * @param len
    +     * @return
    +     * @throws IOException
    +     */
    +    public long consumeUntil(BufferedDataOutputStreamPlus writer, long 
len) throws IOException
    +    {
    +        long copied = 0; // number of bytes copied
    +        while (copied < len)
    +        {
    +            int position = buffer.position();
    +            int remaining = buffer.remaining();
    +            if (remaining == 0)
    +            {
    +                try
    +                {
    +                    reBuffer();
    +                } catch (EOFException e)
    +                {
    +                    throw new EOFException("EOF after " + copied + " bytes 
out of " + len);
    +                }
    +                position = buffer.position();
    +                remaining = buffer.remaining();
    +                if (remaining == 0)
    --- End diff --
    
    My bad. I missed the last part of it.
    
    And me doing something is not an endorsement of it being a good idea/right!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to