Github user iamaleksey commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/239#discussion_r205109588
--- Diff: src/java/org/apache/cassandra/db/compaction/Verifier.java ---
@@ -361,12 +361,26 @@ public RangeOwnHelper(List<Range<Token>>
normalizedRanges)
* @throws RuntimeException if the key is not contained
*/
public void check(DecoratedKey key)
+ {
+ if (!checkBoolean(key))
--- End diff --
Yep, this is exactly what I had in mind, thanks. Not sure of the names,
though. Would prefer the throwing `check()` to be renamed into `validate()`,
and `checkBoolean()` to become `check()`. `validate()` is the name we often
give to such methods (that throw on failure).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
