Github user iamaleksey commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r205445770
  
    --- Diff: 
test/unit/org/apache/cassandra/db/streaming/CassandraStreamHeaderTest.java ---
    @@ -43,8 +51,38 @@ public void serializerTest()
                                                                      new 
ArrayList<>(),
                                                                      
((CompressionMetadata) null),
                                                                      0,
    -                                                                 
SerializationHeader.makeWithoutStats(metadata).toComponent());
    +                                                                 
SerializationHeader.makeWithoutStats(metadata).toComponent(),
    +                                                                 
metadata.id);
     
             SerializationUtils.assertSerializationCycle(header, 
CassandraStreamHeader.serializer);
         }
    +
    +    @Test
    +    public void serializerTest_FullSSTableTransfer()
    +    {
    +        String ddl = "CREATE TABLE tbl (k INT PRIMARY KEY, v INT)";
    +        TableMetadata metadata = CreateTableStatement.parse(ddl, 
"ks").build();
    +
    +        ComponentManifest manifest = new ComponentManifest(new 
HashMap(ImmutableMap.of(Component.DATA, 100L)));
    --- End diff --
    
    No need to wrap the immutable map in a hashmap here (:


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to