Github user jasobrown commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/255#discussion_r213670908
--- Diff: src/java/org/apache/cassandra/tools/fqltool/ResultHandler.java ---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.tools.fqltool;
+
+import java.io.File;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Objects;
+import java.util.stream.Collectors;
+
+import com.google.common.annotations.VisibleForTesting;
+
+import com.datastax.driver.core.ResultSet;
+
+public class ResultHandler
+{
+ private final ResultStore resultStore;
+ private final ResultComparator resultComparator;
+ private final List<String> targetHosts;
+
+ public ResultHandler(List<String> targetHosts, List<File> resultPaths,
File queryFilePath)
+ {
+ this.targetHosts = targetHosts;
+ resultStore = resultPaths != null ? new ResultStore(resultPaths,
queryFilePath) : null;
+ resultComparator = new ResultComparator();
+ }
+
+ /**
+ * Since we can't iterate a ResultSet more than once, and we don't
want to keep the entire result set in memory
+ * we feed the rows one-by-one to resultComparator and resultStore.
+ */
+ public void handleResults(FQLQuery query, List<ComparableResultSet>
results)
+ {
+ for (int i = 0; i < targetHosts.size(); i++)
+ {
+ if (results.get(i).wasFailed())
+ {
+ System.out.println("Query against "+targetHosts.get(i)+"
failure:");
+ System.out.println(query);
+ System.out.println("Message:
"+results.get(i).getFailureException().getMessage());
+ }
+ }
+
+ List<ComparableColumnDefinitions> columnDefinitions =
results.stream().map(ComparableResultSet::getColumnDefinitions).collect(Collectors.toList());
+ resultComparator.compareColumnDefinitions(targetHosts, query,
columnDefinitions);
+ if (resultStore != null)
+ resultStore.storeColumnDefinitions(query, columnDefinitions);
+ List<Iterator<ComparableRow>> iters =
results.stream().map(Iterable::iterator).collect(Collectors.toList());
+
+ while (true)
+ {
+ List<ComparableRow> rows = rows(iters);
+ resultComparator.compareRows(targetHosts, query, rows);
+ if (resultStore != null)
+ resultStore.storeRows(rows);
+ // all rows being null marks end of all resultsets, we need to
call compareRows
+ // and storeRows once with everything null to mark that fact
+ if (rows.stream().allMatch(Objects::isNull))
--- End diff --
Could you make this the condition of the `while` loop, instead of `while
(true)` ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
