Github user jasobrown commented on a diff in the pull request: https://github.com/apache/cassandra/pull/256#discussion_r214221005 --- Diff: src/java/org/apache/cassandra/tools/fqltool/commands/Compare.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.fqltool.commands; + + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.stream.Collectors; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.collect.AbstractIterator; + +import io.airlift.airline.Arguments; +import io.airlift.airline.Command; +import io.airlift.airline.Option; +import net.openhft.chronicle.core.io.Closeable; +import net.openhft.chronicle.queue.ChronicleQueue; +import net.openhft.chronicle.queue.ChronicleQueueBuilder; +import net.openhft.chronicle.queue.ExcerptTailer; +import org.apache.cassandra.tools.fqltool.FQLQueryIterator; +import org.apache.cassandra.tools.fqltool.ResultHandler; +import org.apache.cassandra.tools.fqltool.StoredResultSet; + +/** + */ +@Command(name = "compare", description = "Compare result files generated by fqltool replay") +public class Compare implements Runnable +{ + @Arguments(usage = "<path1> [<path2>...<pathN>]", description = "Directories containing result files to compare.", required = true) + private List<String> arguments = new ArrayList<>(); + + @Option(title = "queries", name = { "--queries"}, description = "Where to read the queries - should be produced by the replay command --store-queries to make sure they are in the same order") + private String querylog; + + @Override + public void run() + { + try --- End diff -- petty nit: probably don't need to wrap `compare{}` in a try/catch as that method already catches all exceptions (and wraps them in a `RuntimeException`
--- --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org