Github user jrwest commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/37#discussion_r218263635
  
    --- Diff: repair_tests/incremental_repair_test.py ---
    @@ -207,6 +208,7 @@ def test_manual_session_fail(self):
             self.fixture_dtest_setup.setup_overrides.cluster_options = 
ImmutableMapping({'hinted_handoff_enabled': 'false',
                                                                                
          'num_tokens': 1,
                                                                                
          'commitlog_sync_period_in_ms': 500})
    +        self.fixture_dtest_setup.init_default_config()
    --- End diff --
    
    Also I'm not sure its clear to me why `init_default_config()` is called 
before every test. Is it because the config changes in the preceding lines 
weren't actually being picked up prior? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to