Github user belliottsmith commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/269#discussion_r218382719
--- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java ---
@@ -328,7 +356,6 @@ else if (useStrictConsistency)
* Get a map of all ranges and the source that will be cleaned up once
this bootstrapped node is added for the given ranges.
* For each range, the list should only contain a single source. This
allows us to consistently migrate data without violating
* consistency.
- *
**/
public static EndpointsByReplica
calculateRangesToFetchWithPreferredEndpoints(BiFunction<InetAddressAndPort,
EndpointsForRange, EndpointsForRange> snitchGetSortedListByProximity,
--- End diff --
A comment specifying the requirement to now provide filters for liveness
and not-self checks would help prevent future misuse, and make it easier to
read the logic.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
