Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/269#discussion_r218554481 --- Diff: src/java/org/apache/cassandra/dht/RangeStreamer.java --- @@ -328,7 +356,6 @@ else if (useStrictConsistency) * Get a map of all ranges and the source that will be cleaned up once this bootstrapped node is added for the given ranges. * For each range, the list should only contain a single source. This allows us to consistently migrate data without violating * consistency. - * **/ public static EndpointsByReplica calculateRangesToFetchWithPreferredEndpoints(BiFunction<InetAddressAndPort, EndpointsForRange, EndpointsForRange> snitchGetSortedListByProximity, --- End diff -- Why should people have to provide the not-self check if everyone needs it? Seems like we should just add it automatically.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org