Github user vinaykumarchella commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/277#discussion_r223518571
  
    --- Diff: 
test/unit/org/apache/cassandra/cache/BlacklistedPartitionsCacheTest.java ---
    @@ -0,0 +1,175 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.cassandra.cache;
    +
    +import org.junit.Assert;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +
    +import com.datastax.driver.core.PreparedStatement;
    +import com.datastax.driver.core.ResultSet;
    +import com.datastax.driver.core.Session;
    +import com.datastax.driver.core.exceptions.InvalidQueryException;
    +import org.apache.cassandra.cql3.CQLTester;
    +import org.apache.cassandra.repair.SystemDistributedKeyspace;
    +import org.apache.cassandra.schema.SchemaConstants;
    +import org.apache.cassandra.utils.ByteBufferUtil;
    +
    +public class BlacklistedPartitionsCacheTest extends CQLTester
    --- End diff --
    
    Can you add a few test cases which can cover different types of partition 
keys (text, int, etc.,)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to