Github user aweisberg commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/283#discussion_r225634901
--- Diff: src/java/org/apache/cassandra/net/IAsyncCallback.java ---
@@ -31,11 +31,23 @@
void response(MessageIn<T> msg);
/**
+ * @deprecated Use {@link #latencyMeasurementType()}. This is left for
backwards
+ * compatibility with existing IAsyncCallback
implementations but will
+ * be removed at a future date.
* @return true if this callback is on the read path and its latency
should be
* given as input to the dynamic snitch.
*/
+ @Deprecated
--- End diff --
Yes we have way too many mock snitches. I think there are some things that
require one to be constructed. I would still make the change, and maybe if
possible consolidate the mock snitches into as few as possible? We definitely
don't want to keep around deprecated internal code and we have to pay whatever
the cost is to get rid of it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
